Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new create-composite command #1106

Merged
merged 1 commit into from
Apr 3, 2019

Conversation

belemaire
Copy link
Member

@belemaire belemaire commented Apr 3, 2019

The current way to create a JS composite project is to use the create-container command along with the --jsOnly flag.

There is -at least- two problems with the current approach :

  1. It creates confusion around platform concepts understanding, especially for new comers.
    The JS Composite is not a Container in itself, so why should one use a create-container command to create a Composite when they are not the same?

  2. It makes the create-container command logic more complex to accommodate this specific option, also because of the fact that some options of the command can only be used when --jsOnly is present or the opposite (also on a most fundamental design note, the current command allows to create a Container OR create a Composite. When a single command can do two different things, that's a code smell).

For these reasons, this PR introduces a new command create-composite that can be used ... well ... to create a Composite. It removes the --jsOnly logic from the create-container command and marks this option as deprecated, informing the user to use the new create-composite command in case this option is set.

For release notes : This is a breaking change !

@belemaire belemaire merged commit 9e62897 into electrode-io:master Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant