Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current way to create a JS composite project is to use the
create-container
command along with the--jsOnly
flag.There is -at least- two problems with the current approach :
It creates confusion around platform concepts understanding, especially for new comers.
The JS Composite is not a Container in itself, so why should one use a
create-container
command to create a Composite when they are not the same?It makes the
create-container
command logic more complex to accommodate this specific option, also because of the fact that some options of the command can only be used when--jsOnly
is present or the opposite (also on a most fundamental design note, the current command allows tocreate a Container
ORcreate a Composite
. When a single command can do two different things, that's a code smell).For these reasons, this PR introduces a new command
create-composite
that can be used ... well ... to create a Composite. It removes the--jsOnly
logic from thecreate-container
command and marks this option as deprecated, informing the user to use the newcreate-composite
command in case this option is set.For release notes : This is a breaking change !