Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SSD1307Driver #624

Merged
merged 4 commits into from
Sep 20, 2024
Merged

Add SSD1307Driver #624

merged 4 commits into from
Sep 20, 2024

Conversation

AndrewCapon
Copy link
Contributor

Added code for SSD1307 displays.

As pimpl is being used I wasn't sure if you wanted any kind of inheritance so SSD1307Driver is a full implementation.

Really only the Init() is any different to the SSD130x

Copy link

github-actions bot commented Apr 28, 2024

Test Results

151 tests  ±0   151 ✅ ±0   0s ⏱️ ±0s
 16 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 765f483. ± Comparison against base commit f7727ed.

♻️ This comment has been updated with latest results.

@AndrewCapon AndrewCapon mentioned this pull request Apr 29, 2024
@stephenhensley
Copy link
Collaborator

Having a full implementation is fine for now.
There are a few other new display drivers being added as well. So we may be able to look at the full set some time down the road and see if there's a decent way to reuse any commonly shared code between them whether that's through some composition or inheritance.

Thanks for the contribution!

@stephenhensley stephenhensley merged commit 98a6626 into electro-smith:master Sep 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants