NextJs Example: fixes for serverless deployment #2103
+60
−65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balegas
had a problem deploying
to
Pull request
GitHub Actions
Failure
thruflo
approved these changes
Dec 9, 2024
kevin-dp
reviewed
Dec 9, 2024
| return NextResponse.json({ id: result.rows[0].id }) | ||
|
|
||
| try { | ||
| await client.connect() |
There was a problem hiding this comment.
If you use a pool you can do pool.query instead of this pattern of having to connect, query, and then disconnect. Same for Line 26.
There was a problem hiding this comment.
yep. applying these changes throughout open PRs as I go through them. thanks you for raising
balegas
force-pushed
the
balegas/nextjs-db-name
branch
from
6dd3d11 to
a3c7bbf
Compare
balegas
had a problem deploying
to
Pull request
GitHub Actions
Failure
kevin-dp
had a problem deploying
to
Pull request
GitHub Actions
Failure
Examples
|
kevin-dp
force-pushed
the
balegas/nextjs-db-name
branch
from
c7b6dbb to
0af76b0
Compare
kevin-dp
had a problem deploying
to
Pull request
GitHub Actions
Failure
balegas
force-pushed
the
balegas/nextjs-db-name
branch
from
707ab8a to
8e405a3
Compare
balegas
had a problem deploying
to
Pull request
GitHub Actions
Failure
kevin-dp
had a problem deploying
to
Pull request
GitHub Actions
Failure
kevin-dp
force-pushed
the
balegas/nextjs-db-name
branch
from
7f0afbd to
78cb6b5
Compare
kevin-dp
had a problem deploying
to
Pull request
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some fixes and updated SST