Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client: expose shape and stream lastOffset via public getter. #1989

Merged
merged 3 commits into from
Nov 19, 2024
Merged

client: expose shape and stream lastOffset via public getter. #1989

merged 3 commits into from
Nov 19, 2024

Conversation

thruflo
Copy link
Contributor

@thruflo thruflo commented Nov 18, 2024

No description provided.

@thruflo thruflo mentioned this pull request Nov 18, 2024
Open
balegas
balegas approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@balegas balegas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is no harm is exposing it.. I've been building on this on the examples.

@thruflo thruflo merged commit 5063314 into main Nov 19, 2024
10 of 13 checks passed
@thruflo thruflo deleted the thruflo/public-last-offset branch November 19, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balegas balegas balegas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thruflo @balegas