fix (generator): fix type error with WhereUniqueInput schemas
#1014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would hold off merging this for the moment because this does not seem to be the only problem introduced by our upgrade to Prisma v5. There is another open issue which is related to that upgrade: #1001. I tested that issue and it works when our generator uses Prisma v4 but not when we use Prisma v5. Again, due to a breaking type change in v5. Perhaps we should revert back to using Prisma v4 also for generating the Prisma client, even though we know that leads to the generator crashing if the user has Prisma v5 installed in their project. |
|
Created a PR for reverting to Prisma v4: #1016 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes type errors in the generated client with
WhereUniqueInputschemas, as reported in: https://discord.com/channels/933657521581858818/1211387122351870072.The type errors come from the fact that we are now using Prisma v5 for generating the Prisma client but in Prisma v5 the type for
WhereUniqueInputschemas is now wrapped in anAtLeast<..., ...>type which is a breaking type change compared to the generated type in v4. Since our Zod schemas are generated using v4 the types are incompatible. This PR patches theAtLeasttype such that the resulting type is equivalent to the type in v4.