Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistently Namespace our Environment Variables with ELECTRIC_ #1927

Closed
KyleAMathews opened this issue Nov 5, 2024 · 1 comment · Fixed by #1928
Closed

Consistently Namespace our Environment Variables with ELECTRIC_ #1927

KyleAMathews opened this issue Nov 5, 2024 · 1 comment · Fixed by #1928

Comments

@KyleAMathews
Copy link
Contributor

Most system software does this e.g. Kubernetes, Redis, MySQL, Postgres, etc. as if you run multiple bits of software in the same environment than it's easy to get namespace clashes.
@KyleAMathews KyleAMathews changed the title Namespace our Environment Variables with ESQL_ Consistently Namespace our Environment Variables with ELECTRIC_ Nov 5, 2024
@thruflo
Copy link
Contributor

thruflo commented Nov 5, 2024

Yup, I think ELECTRIC_ reads much better.

@KyleAMathews KyleAMathews mentioned this issue Nov 5, 2024
Merged
This was referenced Nov 5, 2024
Closed
Merged
KyleAMathews added a commit that referenced this issue Nov 6, 2024
@KyleAMathews
fix: also change DATABASE_ID to ELECTRIC_DATABASE_ID (#1934)
d34cb7e 
Missed this when working on
#1927
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: rename env variables so consitently prefixed with ELECTRIC_ electric-sql/electric
2 participants
@thruflo @KyleAMathews