Properly clean up shape

electric-sql · Nov 26, 2024 · c87c4cd · c87c4cd
1 parent 3d7c423
commit c87c4cd
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/packages/sync-service/lib/electric/shape_cache.ex b/packages/sync-service/lib/electric/shape_cache.ex
@@ -323,8 +323,10 @@ defmodule Electric.ShapeCache do
       rescue
         e ->
           Logger.error("Failed to recover shape #{shape_handle}: #{inspect(e)}")
-          shape_opts = Electric.ShapeCache.Storage.for_shape(shape_handle, state.storage)
-          Electric.ShapeCache.Storage.unsafe_cleanup!({state.storage, shape_opts})
+
+          # clean up corrupted data to avoid persisting bad state
+          Electric.ShapeCache.Storage.for_shape(shape_handle, state.storage)
+          |> Electric.ShapeCache.Storage.unsafe_cleanup!()
       end
     end)
   end