Skip to content
This repository has been archived by the owner on May 30, 2019. It is now read-only.

Commit

Permalink
Fixed some Bundle instances. Work with abstracts.
Browse files Browse the repository at this point in the history
Some bundles were removing console-autoload by themselves. AbstractElcodiBundle do this by default.
  • Loading branch information
mmoreram committed Nov 28, 2015
1 parent 165bddd commit a7ef3d0
Show file tree
Hide file tree
Showing 30 changed files with 70 additions and 480 deletions.
20 changes: 3 additions & 17 deletions src/Elcodi/Bridge/BehatBridgeBundle/BehatBridgeBundle.php
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,14 @@

namespace Elcodi\Bridge\BehatBridgeBundle;

use Symfony\Component\Console\Application;
use Symfony\Component\DependencyInjection\Extension\ExtensionInterface;
use Symfony\Component\HttpKernel\Bundle\Bundle;

use Elcodi\Bundle\CoreBundle\Abstracts\AbstractElcodiBundle;

/**
* Class BehatBridgeBundle
*/
class BehatBridgeBundle extends Bundle
class BehatBridgeBundle extends AbstractElcodiBundle
{
/**
* Returns the bundle's container extension.
Expand All @@ -35,18 +35,4 @@ public function getContainerExtension()
{
return null;
}

/**
* Register Commands.
*
* Disabled as commands are registered as services.
*
* @param Application $application An Application instance
*
* @return null
*/
public function registerCommands(Application $application)
{
return null;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -18,17 +18,16 @@
namespace Elcodi\Bridge\PaymentSuiteBridgeBundle;

use Mmoreram\SymfonyBundleDependencies\DependentBundleInterface;
use Symfony\Component\Console\Application;
use Symfony\Component\DependencyInjection\Extension\ExtensionInterface;
use Symfony\Component\HttpKernel\Bundle\Bundle;
use Symfony\Component\HttpKernel\KernelInterface;

use Elcodi\Bridge\PaymentSuiteBridgeBundle\DependencyInjection\ElcodiPaymentSuiteBridgeExtension;
use Elcodi\Bundle\CoreBundle\Abstracts\AbstractElcodiBundle;

/**
* Class ElcodiPaymentSuiteBridgeBundle
*/
class ElcodiPaymentSuiteBridgeBundle extends Bundle implements DependentBundleInterface
class ElcodiPaymentSuiteBridgeBundle extends AbstractElcodiBundle implements DependentBundleInterface
{
/**
* Returns the bundle's container extension.
Expand All @@ -40,20 +39,6 @@ public function getContainerExtension()
return new ElcodiPaymentSuiteBridgeExtension();
}

/**
* Register Commands.
*
* Disabled as commands are registered as services.
*
* @param Application $application An Application instance
*
* @return null
*/
public function registerCommands(Application $application)
{
return null;
}

/**
* Create instance of current bundle, and return dependent bundle namespaces
*
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,16 +17,15 @@

namespace Elcodi\Bridge\VisithorBridgeBundle;

use Symfony\Component\Console\Application;
use Symfony\Component\DependencyInjection\Extension\ExtensionInterface;
use Symfony\Component\HttpKernel\Bundle\Bundle;

use Elcodi\Bridge\VisithorBridgeBundle\DependencyInjection\ElcodiVisithorBridgeExtension;
use Elcodi\Bundle\CoreBundle\Abstracts\AbstractElcodiBundle;

/**
* Class ElcodiVisithorBridgeBundle
*/
class ElcodiVisithorBridgeBundle extends Bundle
class ElcodiVisithorBridgeBundle extends AbstractElcodiBundle
{
/**
* Returns the bundle's container extension.
Expand All @@ -37,18 +36,4 @@ public function getContainerExtension()
{
return new ElcodiVisithorBridgeExtension();
}

/**
* Register Commands.
*
* Disabled as commands are registered as services.
*
* @param Application $application An Application instance
*
* @return null
*/
public function registerCommands(Application $application)
{
return null;
}
}
19 changes: 2 additions & 17 deletions src/Elcodi/Common/FirewallBundle/ElcodiFirewallBundle.php
Original file line number Diff line number Diff line change
Expand Up @@ -17,19 +17,18 @@

namespace Elcodi\Common\FirewallBundle;

use Symfony\Component\Console\Application;
use Symfony\Component\DependencyInjection\ContainerBuilder;
use Symfony\Component\DependencyInjection\Extension\ExtensionInterface;
use Symfony\Component\HttpKernel\Bundle\Bundle;

use Elcodi\Bundle\CoreBundle\Abstracts\AbstractElcodiBundle;
use Elcodi\Common\FirewallBundle\CompilerPass\FirewallCompilerPass;

/**
* Class ElcodiFirewallBundle
*
* @author Berny Cantos <[email protected]>
*/
class ElcodiFirewallBundle extends Bundle
class ElcodiFirewallBundle extends AbstractElcodiBundle
{
/**
* Builds the bundle.
Expand Down Expand Up @@ -57,18 +56,4 @@ public function getContainerExtension()
{
return null;
}

/**
* Register Commands.
*
* Disabled as commands are registered as services.
*
* @param Application $application An Application instance
*
* @return null
*/
public function registerCommands(Application $application)
{
return null;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -20,17 +20,19 @@
use Mmoreram\SymfonyBundleDependencies\DependentBundleInterface;
use Symfony\Component\DependencyInjection\ContainerBuilder;
use Symfony\Component\DependencyInjection\Extension\ExtensionInterface;
use Symfony\Component\HttpKernel\Bundle\Bundle;
use Symfony\Component\HttpKernel\KernelInterface;

use Elcodi\Bundle\CoreBundle\Abstracts\AbstractElcodiBundle;
use Elcodi\Component\Plugin\Interfaces\PluginInterface;
use Elcodi\Plugin\CustomShippingBundle\CompilerPass\MappingCompilerPass;
use Elcodi\Plugin\CustomShippingBundle\DependencyInjection\ElcodiCustomShippingExtension;

/**
* Class ElcodiCustomShippingBundle
*/
class ElcodiCustomShippingBundle extends Bundle implements PluginInterface, DependentBundleInterface
class ElcodiCustomShippingBundle
extends AbstractElcodiBundle
implements PluginInterface, DependentBundleInterface
{
/**
* Builds the bundle.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
/**
* Class ElcodiShippingRangeTypes
*/
class ElcodiShippingRangeTypes
final class ElcodiShippingRangeTypes
{
/**
* @var string
Expand Down
19 changes: 2 additions & 17 deletions src/Elcodi/Plugin/DisqusBundle/ElcodiDisqusBundle.php
Original file line number Diff line number Diff line change
Expand Up @@ -17,17 +17,16 @@

namespace Elcodi\Plugin\DisqusBundle;

use Symfony\Component\Console\Application;
use Symfony\Component\DependencyInjection\Extension\ExtensionInterface;
use Symfony\Component\HttpKernel\Bundle\Bundle;

use Elcodi\Bundle\CoreBundle\Abstracts\AbstractElcodiBundle;
use Elcodi\Component\Plugin\Interfaces\PluginInterface;
use Elcodi\Plugin\DisqusBundle\DependencyInjection\ElcodiDisqusExtension;

/**
* Class ElcodiDisqusBundle
*/
class ElcodiDisqusBundle extends Bundle implements PluginInterface
class ElcodiDisqusBundle extends AbstractElcodiBundle implements PluginInterface
{
/**
* Returns the bundle's container extension.
Expand All @@ -38,18 +37,4 @@ public function getContainerExtension()
{
return new ElcodiDisqusExtension();
}

/**
* Register Commands.
*
* Disabled as commands are registered as services.
*
* @param Application $application An Application instance
*
* @return null
*/
public function registerCommands(Application $application)
{
return null;
}
}
19 changes: 2 additions & 17 deletions src/Elcodi/Plugin/FacebookBundle/ElcodiFacebookBundle.php
Original file line number Diff line number Diff line change
Expand Up @@ -17,17 +17,16 @@

namespace Elcodi\Plugin\FacebookBundle;

use Symfony\Component\Console\Application;
use Symfony\Component\DependencyInjection\Extension\ExtensionInterface;
use Symfony\Component\HttpKernel\Bundle\Bundle;

use Elcodi\Bundle\CoreBundle\Abstracts\AbstractElcodiBundle;
use Elcodi\Component\Plugin\Interfaces\PluginInterface;
use Elcodi\Plugin\FacebookBundle\DependencyInjection\ElcodiFacebookExtension;

/**
* Class ElcodiFacebookBundle
*/
class ElcodiFacebookBundle extends Bundle implements PluginInterface
class ElcodiFacebookBundle extends AbstractElcodiBundle implements PluginInterface
{
/**
* Returns the bundle's container extension.
Expand All @@ -38,18 +37,4 @@ public function getContainerExtension()
{
return new ElcodiFacebookExtension();
}

/**
* Register Commands.
*
* Disabled as commands are registered as services.
*
* @param Application $application An Application instance
*
* @return null
*/
public function registerCommands(Application $application)
{
return null;
}
}
21 changes: 4 additions & 17 deletions src/Elcodi/Plugin/FreePaymentBundle/ElcodiFreePaymentBundle.php
Original file line number Diff line number Diff line change
Expand Up @@ -18,18 +18,19 @@
namespace Elcodi\Plugin\FreePaymentBundle;

use Mmoreram\SymfonyBundleDependencies\DependentBundleInterface;
use Symfony\Component\Console\Application;
use Symfony\Component\DependencyInjection\Extension\ExtensionInterface;
use Symfony\Component\HttpKernel\Bundle\Bundle;
use Symfony\Component\HttpKernel\KernelInterface;

use Elcodi\Bundle\CoreBundle\Abstracts\AbstractElcodiBundle;
use Elcodi\Component\Plugin\Interfaces\PluginInterface;
use Elcodi\Plugin\FreePaymentBundle\DependencyInjection\ElcodiFreePaymentExtension;

/**
* Class ElcodiFreePaymentBundle
*/
class ElcodiFreePaymentBundle extends Bundle implements PluginInterface, DependentBundleInterface
class ElcodiFreePaymentBundle
extends AbstractElcodiBundle
implements PluginInterface, DependentBundleInterface
{
/**
* Returns the bundle's container extension.
Expand All @@ -41,20 +42,6 @@ public function getContainerExtension()
return new ElcodiFreePaymentExtension();
}

/**
* Register Commands.
*
* Disabled as commands are registered as services.
*
* @param Application $application An Application instance
*
* @return null
*/
public function registerCommands(Application $application)
{
return null;
}

/**
* Create instance of current bundle, and return dependent bundle namespaces
*
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,17 +17,16 @@

namespace Elcodi\Plugin\GoogleAnalyticsBundle;

use Symfony\Component\Console\Application;
use Symfony\Component\DependencyInjection\Extension\ExtensionInterface;
use Symfony\Component\HttpKernel\Bundle\Bundle;

use Elcodi\Bundle\CoreBundle\Abstracts\AbstractElcodiBundle;
use Elcodi\Component\Plugin\Interfaces\PluginInterface;
use Elcodi\Plugin\GoogleAnalyticsBundle\DependencyInjection\ElcodiGoogleAnalyticsExtension;

/**
* Class ElcodiGoogleAnalyticsBundle
*/
class ElcodiGoogleAnalyticsBundle extends Bundle implements PluginInterface
class ElcodiGoogleAnalyticsBundle extends AbstractElcodiBundle implements PluginInterface
{
/**
* Returns the bundle's container extension.
Expand All @@ -38,18 +37,4 @@ public function getContainerExtension()
{
return new ElcodiGoogleAnalyticsExtension();
}

/**
* Register Commands.
*
* Disabled as commands are registered as services.
*
* @param Application $application An Application instance
*
* @return null
*/
public function registerCommands(Application $application)
{
return null;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -18,18 +18,17 @@
namespace Elcodi\Plugin\PaypalWebCheckoutBundle;

use Mmoreram\SymfonyBundleDependencies\DependentBundleInterface;
use Symfony\Component\Console\Application;
use Symfony\Component\DependencyInjection\Extension\ExtensionInterface;
use Symfony\Component\HttpKernel\Bundle\Bundle;
use Symfony\Component\HttpKernel\KernelInterface;

use Elcodi\Bundle\CoreBundle\Abstracts\AbstractElcodiBundle;
use Elcodi\Component\Plugin\Interfaces\PluginInterface;
use Elcodi\Plugin\PaypalWebCheckoutBundle\DependencyInjection\ElcodiPaypalWebCheckoutExtension;

/**
* Class ElcodiPaypalWebCheckoutBundle
*/
class ElcodiPaypalWebCheckoutBundle extends Bundle implements PluginInterface, DependentBundleInterface
class ElcodiPaypalWebCheckoutBundle extends AbstractElcodiBundle implements PluginInterface, DependentBundleInterface
{
/**
* Returns the bundle's container extension.
Expand All @@ -41,20 +40,6 @@ public function getContainerExtension()
return new ElcodiPaypalWebCheckoutExtension();
}

/**
* Register Commands.
*
* Disabled as commands are registered as services.
*
* @param Application $application An Application instance
*
* @return null
*/
public function registerCommands(Application $application)
{
return null;
}

/**
* Create instance of current bundle, and return dependent bundle namespaces
*
Expand Down
Loading

0 comments on commit a7ef3d0

Please sign in to comment.