rook: zap and values fixes #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robinAwallace
requested review from
davidumea,
Pavan-Gunda,
aarnq and
raviranjanelastisys
OlleLarsson
approved these changes
Aug 29, 2023
raviranjanelastisys
approved these changes
Aug 29, 2023
aarnq
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Found two issues when trying it out.
Which issue this PR fixes (use the format
fixes #<issue number>(, fixes #<issue_number>, ...)to automatically close the issue when PR gets merged): fixes #Public facing documentation PR (if applicable)
Special notes for reviewer:
Checklist:
I.e. full cluster migration is required.