added config to enable local volume provisioner #303
Conversation
Pavan-Gunda
requested review from
crssnd,
viktor-f,
OlleLarsson,
lucianvlad and
Xartos
config/openstack/group_vars/k8s_cluster/ck8s-k8s-cluster-openstack.yaml
Outdated
Show resolved
Hide resolved
config/openstack/group_vars/k8s_cluster/ck8s-k8s-cluster-openstack.yaml
Outdated
Show resolved
Hide resolved
| @@ -12,6 +12,7 @@ cinder_csi_enabled: true | |||
| persistent_volumes_enabled: true | |||
There was a problem hiding this comment.
Any reason to only have this for openstack?
I'm guessing we could run this on exoscale for instance as well.
There was a problem hiding this comment.
That is true !!
do you recommend moving it to ck8s-k8s-cluster.yaml ?
There was a problem hiding this comment.
I'm kind of tempted to do so
There was a problem hiding this comment.
Yea, I think that makes sense. It should work for any as long as you set it up correctly. But you've specified in the docs that it's only tested on openstack so that should be fine for now imo.
There was a problem hiding this comment.
But when we do an init with non openstack clouds, these new values won't show up in the rendered manifests, so I want to propose moving the values to ck8s-k8s-cluster.yaml
There was a problem hiding this comment.
This does not seem to work for Cleura
We need to test and make it work on all cloud providers
There was a problem hiding this comment.
This does not seem to work for Cleura We need to test and make it work on all cloud providers
No we don't. This is a public repo so I will skip the internal business related stuff but local storage is to only be offered, initially, on the infrastructure providers elastx and safespring.
There was a problem hiding this comment.
But when we do an init with non openstack clouds, these new values won't show up in the rendered manifests, so I want to propose moving the values to ck8s-k8s-cluster.yaml
Any thoughts ? if not, i'll keep them in openstack manifests since we are currently only offering it in elastx and safespring.
There was a problem hiding this comment.
But when we do an init with non openstack clouds, these new values won't show up in the rendered manifests, so I want to propose moving the values to ck8s-k8s-cluster.yaml
So, if you move the values to ck8s-k8s-cluster.yaml they will show up when doing an init on non-openstack clouds?
| @@ -12,6 +12,7 @@ cinder_csi_enabled: true | |||
| persistent_volumes_enabled: true | |||
There was a problem hiding this comment.
But when we do an init with non openstack clouds, these new values won't show up in the rendered manifests, so I want to propose moving the values to ck8s-k8s-cluster.yaml
So, if you move the values to ck8s-k8s-cluster.yaml they will show up when doing an init on non-openstack clouds?
|
If we move it to https://github.com/elastisys/compliantkubernetes-kubespray/blob/main/config/common/group_vars/k8s_cluster/ck8s-k8s-cluster.yaml yes, it should show up in the rendered manifests. |
Then it should like a good thing to move it there |
Pavan-Gunda
force-pushed
the
pg/local-volume-provisioner
branch
from
0c1d7f3 to
221b80c
Compare
Pavan-Gunda
force-pushed
the
pg/local-volume-provisioner
branch
from
bc3745d to
fe86c5a
Compare
What this PR does / why we need it:
Which issue this PR fixes (use the format
fixes #<issue number>(, fixes #<issue_number>, ...)to automatically close the issue when PR gets merged): fixes #238Public facing documentation PR (if applicable)
Special notes for reviewer:
Checklist:
I.e. full cluster migration is required.