Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ck8s with Welkin in tests #2392

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

anders-elastisys
Copy link
Contributor

@anders-elastisys anders-elastisys commented Jan 14, 2025

Warning

This is a public repository, ensure not to disclose:

  • personal data beyond what is necessary for interacting with this pull request, nor
  • business confidential information, such as customer names.

What kind of PR is this?

Required: Mark one of the following that is applicable:

  • kind/feature
  • kind/improvement
  • kind/deprecation
  • kind/documentation
  • kind/clean-up
  • kind/bug
  • kind/other

Optional: Mark one or more of the following that are applicable:

Important

Breaking changes should be marked kind/admin-change or kind/dev-change depending on type
Critical security fixes should be marked with kind/security

  • kind/admin-change
  • kind/dev-change
  • kind/security
  • [kind/adr](set-me)

What does this PR do / why do we need this PR?

The end-to-end tests for Grafana failed as they look for Compliant Kubernetes in the welcome dashboard, which has been updated to use Welkin:

# cypress run: /home/anders/ck8s/compliantkubernetes-apps/tests/end-to-end/grafana/authentication.cy.js
ok 1 grafana admin authentication can login via static admin user
ok 2 grafana admin authentication can login via static dex user
not ok 3 grafana dev authentication can login via static admin user
# (from function `fail' in file /usr/local/lib/bats/support/src/error.bash, line 40,
#  from function `cypress_test' in file end-to-end/grafana/../../bats.lib.bash, line 262,
#  in test file end-to-end/grafana/authentication.gen.bats, line 27)
#   `cypress_test "grafana dev authentication can login via static admin user"' failed
# AssertionError: Timed out retrying after 10000ms: Expected to find content: 'Welcome to Compliant Kubernetes' but never did.

This PR updates the test to fix this.

  • Fixes #

Information to reviewers

Checklist

  • Proper commit message prefix on all commits
  • Change checks:
    • The change is transparent
    • The change is disruptive
    • The change requires no migration steps
    • The change requires migration steps
    • The change updates CRDs
    • The change updates the config and the schema
  • Documentation checks:
  • Metrics checks:
    • The metrics are still exposed and present in Grafana after the change
    • The metrics names didn't change (Grafana dashboards and Prometheus alerts required no updates)
    • The metrics names did change (Grafana dashboards and Prometheus alerts required an update)
  • Logs checks:
    • The logs do not show any errors after the change
  • PodSecurityPolicy checks:
    • Any changed Pod is covered by Kubernetes Pod Security Standards
    • Any changed Pod is covered by Gatekeeper Pod Security Policies
    • The change does not cause any Pods to be blocked by Pod Security Standards or Policies
  • NetworkPolicy checks:
    • Any changed Pod is covered by Network Policies
    • The change does not cause any dropped packets in the NetworkPolicy Dashboard
  • Audit checks:
    • The change does not cause any unnecessary Kubernetes audit events
    • The change requires changes to Kubernetes audit policy
  • Falco checks:
    • The change does not cause any alerts to be generated by Falco
  • Bug checks:
    • The bug fix is covered by regression tests

Copy link
Contributor

@aarnq aarnq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anders-elastisys anders-elastisys marked this pull request as ready for review January 15, 2025 08:07
@anders-elastisys anders-elastisys requested a review from a team as a code owner January 15, 2025 08:07
@anders-elastisys anders-elastisys merged commit 1bc3731 into main Jan 15, 2025
13 checks passed
@anders-elastisys anders-elastisys deleted the anders-elastisys/update-tests-with-welkin branch January 15, 2025 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants