Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ingress-nginx chart to 4.11.2 and app to 1.11.2 #2243

Merged
merged 2 commits into from
Aug 26, 2024

Conversation

davidumea
Copy link
Contributor

@davidumea davidumea commented Aug 22, 2024

Warning

This is a public repository, ensure not to disclose:

  • personal data beyond what is necessary for interacting with this pull request, nor
  • business confidential information, such as customer names.

What kind of PR is this?

Required: Mark one of the following that is applicable:

  • kind/feature
  • kind/improvement
  • kind/deprecation
  • kind/documentation
  • kind/clean-up
  • kind/bug
  • kind/other

Optional: Mark one or more of the following that are applicable:

Important

Breaking changes should be marked kind/admin-change or kind/dev-change depending on type
Critical security fixes should be marked with kind/security

  • kind/admin-change
  • kind/dev-change
  • kind/security
  • kind/adr

Release notes

Drops support for Kubernetes v1.25, adds support for Kubernetes v1.30.
Nginx version upgrade to 1.25.5.

What does this PR do / why do we need this PR?

Upgrades ingress-nginx to chart version 4.11.2 and app version 1.11.2.
Also exposed topologySpreadConstraints for default backend to apps config since this was also exposed in upstream values.

Information to reviewers

Checklist

  • Proper commit message prefix on all commits
  • Change checks:
    • The change is transparent
    • The change is disruptive
    • The change requires no migration steps
    • The change requires migration steps
    • The change upgrades CRDs
    • The change updates the config and the schema
  • Metrics checks:
    • The metrics are still exposed and present in Grafana after the change
    • The metrics names didn't change (Grafana dashboards and Prometheus alerts are not affected)
    • The metrics names did change (Grafana dashboards and Prometheus alerts were fixed)
  • Logs checks:
    • The logs do not show any errors after the change
  • Pod Security Policy checks:
    • Any changed pod is covered by Pod Security Admission
    • Any changed pod is covered by Gatekeeper Pod Security Policies
    • The change does not cause any pods to be blocked by Pod Security Admission or Policies
  • Network Policy checks:
    • Any changed pod is covered by Network Policies
    • The change does not cause any dropped packets in the NetworkPolicy Dashboard
  • Audit checks:
    • The change does not cause any unnecessary Kubernetes audit events
    • The change requires changes to Kubernetes audit policy
  • Falco checks:
    • The change does not cause any alerts to be generated by Falco
  • Bug checks:
    • The bug fix is covered by regression tests

@davidumea davidumea added kind/improvement Improvement of existing features, e.g. code cleanup or optimizations. app/ingress-nginx Ingress NGINX - Ingress Controller labels Aug 22, 2024
@OlleLarsson
Copy link
Contributor

OlleLarsson commented Aug 22, 2024

Any notable changes between ingress-nginx 1.9 and 1.11?
Annotation changes, nginx version, or similar?

@davidumea
Copy link
Contributor Author

Any notable changes between ingress-nginx 1.9 and 1.11? Annotation changes, nginx version, or similar?

Nginx version is updated from 1.21.6 to 1.25.5, I looked through the changelog and I don't think that any of the changes will affect us.

Yes some annotation changes were made, SSLv2, SSLv3, TLSv1 & TLSv1.1 support was dropped. I guess I should add a platform administrator notice for this?

@davidumea
Copy link
Contributor Author

Yes some annotation changes were made, SSLv2, SSLv3, TLSv1 & TLSv1.1 support was dropped. I guess I should add a platform administrator notice for this?

Nevermind, that was just a cleanup PR, support for TLS v1.0 and v1.1 was already dropped since earlier.

@davidumea davidumea force-pushed the david/upgrade-ingress-nginx branch from 7039707 to 4504e4c Compare August 26, 2024 10:51
@davidumea davidumea merged commit 59e50ee into main Aug 26, 2024
11 checks passed
@davidumea davidumea deleted the david/upgrade-ingress-nginx branch August 26, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app/ingress-nginx Ingress NGINX - Ingress Controller kind/improvement Improvement of existing features, e.g. code cleanup or optimizations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[2] Upgrade Ingress-nginx to newer version
5 participants