Handle empty attachments correctly

.circleci/config.yml

@@ -2,7 +2,7 @@ version: 2
 jobs:
   test:
     docker:
-      - image: circleci/node:8-stretch
+      - image: circleci/node:12-stretch
     steps:
       - checkout
       - restore_cache:
@@ -41,4 +41,4 @@ workflows:
           filters:
             branches:
               only:
-                - master
+                - master

CHANGELOG.md

@@ -1,6 +1,9 @@
-## 1.3.1 (May 13, 2020)
+## 1.3.1 (May 22, 2020)
 
 * Update sailor version to 2.6.7
+* Correctly handle incoming attachments that are empty.
+* Update dependencies.
+* Add debug log statements.
 
 ## 1.3.0 (April 23, 2020)
 

lib/actions/attachmentToJson.js

@@ -47,17 +47,26 @@ module.exports.process = async function processAction(msg, cfg) {
         // eslint-disable-next-line no-await-in-loop
         const response = await new AttachmentProcessor().getAttachment(attachment.url, 'arraybuffer');
 
+        this.logger.debug(`For filename ${fileName} Response status: ${response.status} Response headers: ${JSON.stringify(response.headers)}`);
+
         if (response.status >= 400) {
           throw new Error(`Error in making request to ${attachment.url}
-                                      Status code: ${response.status}, 
+                                      Status code: ${response.status},
                                       Body: ${Buffer.from(response.data, 'binary').toString('base64')}`);
         }
 
         const responseBodyString = Buffer.from(response.data, 'binary').toString('utf-8');
+
+        if (!responseBodyString) {
+          throw new Error(`Empty attachment received for file ${fileName}`);
+        }
+
+        this.logger.debug(`For filename ${fileName} Response Body string: ${responseBodyString}`);
         fileSize = sizeof(responseBodyString);
 
         if (fileSize < MAX_FILE_SIZE) {
           const returnMsg = await xml2Json.process(this, responseBodyString);
+          this.logger.debug(`For filename ${fileName} Result of XML Conversion: ${JSON.stringify(returnMsg)}`);
           foundXML = true;
           await self.emit('data', messages.newMessageWithBody(returnMsg.body));
         } else {

lib/xml2Json.js

@@ -5,6 +5,10 @@ const invalidXmlMessage = 'Given XML is not valid or the file can not be read. '
   + 'See XML naming rules https://www.w3schools.com/xml/xml_elements.asp';
 
 module.exports.process = async function xml2Json(self, xmlString) {
+  if (!xmlString) {
+    throw new Error('XML string is missing');
+  }
+
   const parser = new xml2js.Parser({
     trim: false,
     normalize: false,