Minor improvements

lib/httpComponent.js

@@ -8,11 +8,11 @@ exports.HttpComponent = HttpComponent;
 function HttpComponent(component) {
     this.component = component;
     this.statusCodesToRebound = [];
-    this.responseHandler = null;
+    this.handleResponse = null;
 }
 
-HttpComponent.prototype.success = function success(responseHandler) {
-    this.responseHandler = responseHandler;
+HttpComponent.prototype.success = function success(handleResponse) {
+    this.handleResponse = handleResponse;
 
     return this;
 };
@@ -32,30 +32,38 @@ HttpComponent.prototype.reboundOnStatusCode = function reboundOnStatusCode(statu
     return this;
 };
 
-HttpComponent.prototype.exec = function exec(method, requestOptions) {
-    if (!this.responseHandler) {
-        throw new Error("Response handler is required. Please set it through HttpComponent.onResponse");
+HttpComponent.prototype.get = function get(requestOptions) {
+    doRequest.apply(this, ['get', requestOptions]);
+};
+
+HttpComponent.prototype.put = function get(requestOptions) {
+    doRequest.apply(this, ['put', requestOptions]);
+};
+
+HttpComponent.prototype.post = function get(requestOptions) {
+    doRequest.apply(this, ['post', requestOptions]);
+};
+
+function doRequest(method, requestOptions) {
+    if (!this.handleResponse) {
+        throw new Error("Response handler is required. Please set it through HttpComponent.success");
     }
 
     var self = this;
     var emitter = this.component;
 
     Q.nfcall(request[method], requestOptions)
-        .then(transformArrayToObject)
-        .then(self.handleResponse)
+        .spread(self.handleResponse)
         .then(emitMessage)
         .fail(handleError)
         .done(done);
 
-    function transformArrayToObject(output) {
-        return Q({
-            response: output[0],
-            body: output[1]
-        });
-    }
-
     function emitMessage(msg) {
-        emitter.emit('data', msg);
+        if (msg) {
+            emitter.emit('data', msg);
+        } else {
+            console.log('Component produced no data');
+        }
     }
 
     function handleError(err) {
@@ -74,4 +82,4 @@ HttpComponent.prototype.exec = function exec(method, requestOptions) {
     function done() {
         emitter.emit('end');
     }
-};
+}

spec/httpComponent.spec.js

@@ -1,11 +1,10 @@
 describe('Http Component', function () {
 
-    var Q = require('q');
     var nock = require('nock');
     var HttpComponent = require('../lib/httpComponent.js').HttpComponent;
     var messages = require('../lib/messages.js');
 
-    it('should work', function () {
+    it('GET', function () {
 
         nock('http://foobarbazbarney.com')
             .get('/api')
@@ -22,16 +21,108 @@ describe('Http Component', function () {
             json: true
         };
 
-        function handleResponse(response) {
-            return Q(messages.newMessageWithBody(response.body));
+        function handleResponse(response, body) {
+            return messages.newMessageWithBody(body);
         }
 
         var component = new HttpComponent(emitter)
             .success(handleResponse);
 
         runAndExpect(
             function () {
-                component.exec('get', options);
+                component.get(options);
+            },
+            function () {
+                return emitter.emit.callCount === 2;
+            },
+            function () {
+                var emitCalls = emitter.emit.calls;
+
+                var emitDataArgs = emitCalls[0].args;
+
+                expect(emitDataArgs[0]).toEqual('data');
+                expect(emitDataArgs[1].body).toEqual({
+                    foo: 'bar',
+                    baz: 'barney'
+                });
+
+                expect(emitCalls[1].args).toEqual(['end']);
+            });
+    });
+
+    it('POST', function () {
+
+        nock('http://foobarbazbarney.com')
+            .post('/api')
+            .reply(200, JSON.stringify({
+                foo: 'bar',
+                baz: 'barney'
+            }));
+
+
+        var emitter = jasmine.createSpyObj('emitter', ['emit']);
+
+        var options = {
+            url: 'http://foobarbazbarney.com/api',
+            json: true
+        };
+
+        function handleResponse(response, body) {
+            return messages.newMessageWithBody(body);
+        }
+
+        var component = new HttpComponent(emitter)
+            .success(handleResponse);
+
+        runAndExpect(
+            function () {
+                component.post(options);
+            },
+            function () {
+                return emitter.emit.callCount === 2;
+            },
+            function () {
+                var emitCalls = emitter.emit.calls;
+
+                var emitDataArgs = emitCalls[0].args;
+
+                expect(emitDataArgs[0]).toEqual('data');
+                expect(emitDataArgs[1].body).toEqual({
+                    foo: 'bar',
+                    baz: 'barney'
+                });
+
+                expect(emitCalls[1].args).toEqual(['end']);
+            });
+    });
+
+    it('PUT', function () {
+
+        nock('http://foobarbazbarney.com')
+            .put('/api')
+            .reply(200, JSON.stringify({
+                foo: 'bar',
+                baz: 'barney'
+            }));
+
+
+        var emitter = jasmine.createSpyObj('emitter', ['emit']);
+
+        var options = {
+            url: 'http://foobarbazbarney.com/api',
+            json: true
+        };
+
+        function handleResponse(response, body) {
+            return messages.newMessageWithBody(body);
+        }
+
+        var component = new HttpComponent(emitter)
+            .success(handleResponse);
+
+        runAndExpect(
+            function () {
+                component.put(options);
             },
             function () {
                 return emitter.emit.callCount === 2;