Add max_primary_shard_docs condition to ILM rollover
#845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💚 CLA has been signed |
arenard
pushed a commit
to arenard/terraform-provider-elasticstack
that referenced
this pull request
Oct 15, 2024
* Add `max_primary_shard_docs` condition to rollover * Update test for rollover `max_primary_shard_docs` condition * Specify min version in the description * Update CHANGELOG.md
arenard
force-pushed
the
add-ilm-rollover-max-primary-shard-docs
branch
from
eaf341f to
f16e3b4
Compare
arenard
commented
Oct 15, 2024
internal/elasticsearch/index/ilm.go
Outdated
| "priority": {skipEmptyCheck: true}, | ||
| "max_primary_shard_docs": {minVersion: version.Must(version.NewVersion("8.2.0"))}, |
There was a problem hiding this comment.
I am not sure about what should be put there as this property is optional. Maybe a skipEmptyCheck should be added there.
There was a problem hiding this comment.
I think this should be fine, skipEmptyCheck is around dealing with how the TF SDK represents unset attributes as Golang zero values.
arenard
pushed a commit
to arenard/terraform-provider-elasticstack
that referenced
this pull request
Oct 15, 2024
* Add `max_primary_shard_docs` condition to rollover * Update test for rollover `max_primary_shard_docs` condition * Specify min version in the description * Update CHANGELOG.md
arenard
force-pushed
the
add-ilm-rollover-max-primary-shard-docs
branch
from
f16e3b4 to
b97f1c7
Compare
arenard
pushed a commit
to arenard/terraform-provider-elasticstack
that referenced
this pull request
Oct 15, 2024
* Add `max_primary_shard_docs` condition to rollover * Update test for rollover `max_primary_shard_docs` condition * Specify min version in the description * Update CHANGELOG.md
arenard
force-pushed
the
add-ilm-rollover-max-primary-shard-docs
branch
from
b97f1c7 to
3136fbc
Compare
tobio
reviewed
Oct 16, 2024
| @@ -273,12 +274,13 @@ resource "elasticstack_elasticsearch_index_lifecycle" "test_rollover" { | |||
| max_age = "7d" | |||
| max_docs = 10000 | |||
| max_size = "100gb" | |||
| max_primary_shard_docs = 5000 | |||
There was a problem hiding this comment.
We'll want to update the tests to only specify this when it's supported by the backing cluster. That means adding a case covering this attribute which is skipped when it's not supported (example)
* Add `max_primary_shard_docs` condition to rollover * Update test for rollover `max_primary_shard_docs` condition * Specify min version in the description * Update CHANGELOG.md
tobio
force-pushed
the
add-ilm-rollover-max-primary-shard-docs
branch
from
3e169ec to
2430e93
Compare
tobio
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
max_primary_shard_docscondition to rollover (closes [Bug] max_primary_shard_docs variable is not supported in elasticstack_elasticsearch_index_lifecycle.hot.rollover #794)Update test for rollover
max_primary_shard_docsconditionSpecify min version in the description
Update CHANGELOG.md