Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support import of the index settings #55

Merged
merged 5 commits into from
Feb 2, 2022
Merged

Conversation

olksdr
Copy link
Contributor

@olksdr olksdr commented Feb 1, 2022

Make sure we are able to import all the index settings. Also, after index is created we support only the settings, which are defined in the TF files.

fix #53

This way we always import all the supported index settings, but once the
settings are defined in the TF files, we support those which are there
and do not try to import anything else which is not defined
@olksdr olksdr added bug Something isn't working Elasticsearch Elasticsearch related APIs labels Feb 1, 2022
@olksdr olksdr requested review from gtback and Crazybus February 1, 2022 13:25
@olksdr olksdr self-assigned this Feb 1, 2022
Copy link
Member

@gtback gtback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't feel qualified to give this a +1, but it all looks good to me.

Copy link
Contributor

@Crazybus Crazybus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@olksdr olksdr merged commit 7118919 into elastic:main Feb 2, 2022
@olksdr olksdr deleted the fix/index-import branch February 2, 2022 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Elasticsearch Elasticsearch related APIs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Index settings not being imported to terraform
3 participants