Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data view resource #502

Merged
merged 9 commits into from
Dec 12, 2023
Merged

Add data view resource #502

merged 9 commits into from
Dec 12, 2023

Conversation

tobio
Copy link
Member

@tobio tobio commented Dec 6, 2023

Fixes #75

Adds a new resource to manage Kibana data views. This also updates some of the existing generated clients to use the latest codegen version.

@tobio tobio self-assigned this Dec 6, 2023
@tobio tobio requested review from wandergeek and dimuon December 6, 2023 10:44
wandergeek
wandergeek previously approved these changes Dec 8, 2023
Copy link
Contributor

@wandergeek wandergeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I feel like putting the regenerated clients in another PR might be better, but not essential. People will be stoked about this.

Makefile Outdated Show resolved Hide resolved
internal/kibana/data_view/schema_test.go Show resolved Hide resolved
wandergeek
wandergeek previously approved these changes Dec 10, 2023
* origin/main:
  Updating role mapping name field to update or delete role mappings wh… (#503)
@tobio tobio merged commit 365f43c into main Dec 12, 2023
29 checks passed
@tobio tobio deleted the data-views branch December 12, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add the ability to add data views (ex index pattern)
2 participants