Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Fleet agent policy and enrollment tokens #322

Merged
merged 6 commits into from
May 16, 2023
Merged

Add Fleet agent policy and enrollment tokens #322

merged 6 commits into from
May 16, 2023

Conversation

taylor-swanson
Copy link
Contributor

  • Add Fleet agent policy resource type
  • Add Fleet enrollment token data source type
  • Add new types to Fleet generator
  • Add missing requestBody field in Fleet OpenAPI struct

@taylor-swanson
Add Fleet agent policy and enrollment tokens
00152e1 
- Add Fleet agent policy resource type
- Add Fleet enrollment token data source type
- Add new types to Fleet generator
- Add missing requestBody field in Fleet OpenAPI struct
@taylor-swanson
Update changelog
3e33f2b
@taylor-swanson
Fix up acc tests
626e79a
@taylor-swanson
Raise acc test minimum versions to 8.6.0
8295556 
- While the stack supports these endpoints at earlier versions, there
are fields missing in these versions that cause 400 errors.
@taylor-swanson taylor-swanson marked this pull request as ready for review May 9, 2023 13:36
tobio
tobio reviewed May 12, 2023
View reviewed changes
Copy link
Member

@tobio tobio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great, couple of small comments.

internal/fleet/agent_policy_resource_test.go Show resolved Hide resolved
internal/fleet/agent_policy_resource.go Outdated Show resolved Hide resolved
internal/fleet/agent_policy_resource.go Show resolved Hide resolved
internal/fleet/enrollment_tokens_data_source.go Outdated Show resolved Hide resolved
internal/fleet/enrollment_tokens_data_source_test.go Show resolved Hide resolved
internal/fleet/enrollment_tokens_data_source.go Show resolved Hide resolved
tobio
tobio approved these changes May 16, 2023
View reviewed changes
Copy link
Member

@tobio tobio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@tobio tobio merged commit 60113b1 into elastic:main May 16, 2023
@taylor-swanson taylor-swanson deleted the fleet-resources branch May 16, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobio tobio tobio approved these changes

Assignees

@taylor-swanson taylor-swanson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taylor-swanson @tobio