-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE-278] Resolve pipeline_metadata.version
error
#294
Conversation
pipeline_metadata.version
error
@tobio - Hey, another small one for when you have a spare min or two 👍 Unfortunately I couldn't find a way to handle multiple data types in TypeMap... (please do enlighten me if this is possible though!) Have also just deprecated the field as opposed to introducing a breaking change by replacing, so technically the error still exists in the old |
I'm inclined to just make this a breaking change. It seems like the current field will crash the provider quite easily, and migrating to the new schema is relatively simple (i.e wrap in @Kushmaro do you have an opinion here? |
@RobsonSutton, lets do this. It's nicer to break this now and completely close of this bug. |
@tobio - Should be updated to be a breaking change now 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉 thanks for tidying this code up :)
pipeline_metadata
to schema.TypeString - This setting throws an error when the pipeline is updated manually, as the subsequent terraform plan cannot handle the version value being of type: float64.