Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE-278] Resolve pipeline_metadata.version error #294

Merged
merged 13 commits into from
Apr 4, 2023

Conversation

RobsonSutton
Copy link
Contributor

@RobsonSutton RobsonSutton commented Mar 24, 2023

@RobsonSutton RobsonSutton changed the title [ISSUE-278] Add new metadata field [ISSUE-278] Resolve pipeline_metadata.version error Mar 24, 2023
@RobsonSutton
Copy link
Contributor Author

@tobio - Hey, another small one for when you have a spare min or two 👍

Unfortunately I couldn't find a way to handle multiple data types in TypeMap... (please do enlighten me if this is possible though!)

Have also just deprecated the field as opposed to introducing a breaking change by replacing, so technically the error still exists in the old pipeline_settings, but this should provide a workaround for those that may run into it until the older field is fully removed

@tobio
Copy link
Member

tobio commented Mar 27, 2023

I'm inclined to just make this a breaking change. It seems like the current field will crash the provider quite easily, and migrating to the new schema is relatively simple (i.e wrap in jsonencode()).

@Kushmaro do you have an opinion here?

@tobio
Copy link
Member

tobio commented Apr 2, 2023

I'm inclined to just make this a breaking change.

@RobsonSutton, lets do this. It's nicer to break this now and completely close of this bug.

@RobsonSutton
Copy link
Contributor Author

@tobio - Should be updated to be a breaking change now 👍

Copy link
Member

@tobio tobio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉 thanks for tidying this code up :)

@tobio tobio merged commit 46a8fcf into elastic:main Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants