Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add elasticsearch enrich policy datasource #293

Merged
merged 9 commits into from
Mar 23, 2023

Conversation

jonjitsu
Copy link
Contributor

This PR adds a datasource for looking up enrich policies.

Copy link
Member

@tobio tobio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to take a better look here but a couple of small points.

👍 On getting the data sources added too.

internal/elasticsearch/enrich/policy_data_source.go Outdated Show resolved Hide resolved
templates/data-sources/elasticsearch_enrich_policy.md.tmpl Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
tobio
tobio previously approved these changes Mar 23, 2023
Copy link
Member

@tobio tobio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, great to see more API coverage in the provider.

CHANGELOG.md Outdated Show resolved Hide resolved
@tobio tobio enabled auto-merge (squash) March 23, 2023 21:39
@tobio tobio merged commit c311bbe into elastic:main Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants