Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for API Key management #193

Merged
merged 22 commits into from
Nov 21, 2022
Merged

Add support for API Key management #193

merged 22 commits into from
Nov 21, 2022

Conversation

webfella
Copy link

Implements the ability to manage/create API keys via Terraform, based on some of the initial work done here.

Closes #70.

@webfella webfella requested a review from tobio November 16, 2022 01:03
@webfella webfella self-assigned this Nov 16, 2022
tobio
tobio reviewed Nov 16, 2022
View reviewed changes
Copy link
Member

@tobio tobio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of minor comments.

internal/clients/security.go Outdated Show resolved Hide resolved
internal/clients/security.go Outdated Show resolved Hide resolved
internal/clients/security.go Outdated Show resolved Hide resolved
internal/clients/security.go Outdated Show resolved Hide resolved
internal/clients/security.go Outdated Show resolved Hide resolved
internal/elasticsearch/security/api_key.go Outdated Show resolved Hide resolved
internal/elasticsearch/security/api_key.go Outdated Show resolved Hide resolved
@webfella webfella requested a review from tobio November 19, 2022 08:41
webfella and others added 21 commits November 21, 2022 11:22
tobio
tobio reviewed Nov 21, 2022
View reviewed changes
Copy link
Member

@tobio tobio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Being a pedant, sorry.

internal/elasticsearch/security/api_key_test.go Outdated Show resolved Hide resolved
@webfella webfella merged commit a7c3cb4 into elastic:main Nov 21, 2022
@webfella webfella deleted the api-keys branch November 21, 2022 00:53
@jitbasemartin
Copy link

Thanks @webfella !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobio tobio tobio approved these changes

Assignees

@webfella webfella

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Support for API Key Management
3 participants
@webfella @jitbasemartin @tobio