Add system-user resource #188
Conversation
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
k-yomo
force-pushed
the
add-system-user-resource
branch
from
0c87ba2 to
6cb177c
Compare
k-yomo
force-pushed
the
add-system-user-resource
branch
from
6cb177c to
59256e1
Compare
| Importer: &schema.ResourceImporter{ | ||
| StateContext: schema.ImportStatePassthroughContext, | ||
| }, |
There was a problem hiding this comment.
I'm not sure it ever makes sense to import this resource? A user would never be able to import the password/hash and so it's pretty likely there would be changes to be applied.
Given the 'create' doesn't actually create the user I'd be inclined to just make this not importable. WDYT?
| Importer: &schema.ResourceImporter{ | |
| StateContext: schema.ImportStatePassthroughContext, | |
| }, |
There was a problem hiding this comment.
Oh that's true and making the resource not importable makes sense.
Fixed it!
a641bcd
| resource "elasticstack_elasticsearch_security_system_user" "kibana_system" { | ||
| username = "kibana_system" | ||
|
|
||
| // use hashed password: see https://www.elastic.co/guide/en/elasticsearch/reference/current/security-api-put-user.html#security-api-put-user-request-body |
There was a problem hiding this comment.
I initially read this comment as if I couldn't set the plaintext password.
| // use hashed password: see https://www.elastic.co/guide/en/elasticsearch/reference/current/security-api-put-user.html#security-api-put-user-request-body | |
| // For details on how to generate the hashed password see https://www.elastic.co/guide/en/elasticsearch/reference/current/security-api-put-user.html#security-api-put-user-request-body |
Co-authored-by: Toby Brain <[email protected]>
Co-authored-by: Toby Brain <[email protected]>
|
Can we get a release? Please 😍 |
|
@Fuco1 we'll have a release out in the next 2 weeks |
Resolves #104
This PR adds
elasticstack_elasticsearch_security_system_userresource to manage built-in system user.