Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass context to api calls #138

Merged
merged 4 commits into from
Sep 12, 2022
Merged

Conversation

k-yomo
Copy link
Contributor

@k-yomo k-yomo commented Sep 10, 2022

This PR refactors methods to pass context to api calls to be context aware.

@elasticmachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@k-yomo k-yomo marked this pull request as ready for review September 10, 2022 08:36
@tobio
Copy link
Member

tobio commented Sep 12, 2022

jenkins test this

@tobio
Copy link
Member

tobio commented Sep 12, 2022

@k-yomo are you able to add a changelog entry here?

@k-yomo
Copy link
Contributor Author

k-yomo commented Sep 12, 2022

@tobio
I added to changelog! Also fixed missing parameter error🙏

@tobio
Copy link
Member

tobio commented Sep 12, 2022

jenkins test this

Copy link
Member

@tobio tobio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! I'll look at shipping a release this week, there's some useful changes in the unreleased set here.

@tobio tobio merged commit 2168f05 into elastic:main Sep 12, 2022
@k-yomo k-yomo deleted the pass-context-to-api-call branch September 12, 2022 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants