-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Buildkite pipeline for acceptance tests #741
Conversation
Porting the acceptance job to Buildkite. I moved all the logic of the Makefile into a more Buildkite way of handling secrets (via pre-command) to benefit from secrets redaction.
This reverts commit 4211c0e.
catalog-info.yaml
Outdated
spec: | ||
repository: elastic/terraform-provider-ec | ||
pipeline_file: ".buildkite/pipeline.yml" | ||
teams: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The below team perms mirror the current GitHub permissions on the repository - this is also reflected in the GH repository RE : https://github.com/elastic/catalog-info/pull/635
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Description
Migrate the Jenkins Acceptance tests pipeline to Buildkite.
Notes:
EC_API_KEY
into the pre-command hook under theTERRAFORM_PROVIDER_API_KEY_SECRET
variable - this allows us to benefit from Buildkite's built-in secrets redaction (see doc).ci/Makefile
or any of its target, but we should keep it around for developers to run this locally (tho we may need to update the secrets path to point to the new ci-vault-path)Related Issues
Motivation and Context
How Has This Been Tested?
Types of Changes
Readiness Checklist