Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buildkite pipeline for acceptance tests #741

Merged
merged 8 commits into from
Nov 22, 2023
Merged

Buildkite pipeline for acceptance tests #741

merged 8 commits into from
Nov 22, 2023

Conversation

nkammah
Copy link
Contributor

@nkammah nkammah commented Nov 21, 2023

Description

Migrate the Jenkins Acceptance tests pipeline to Buildkite.

Notes:

  • I moved all logic to load EC_API_KEY into the pre-command hook under the TERRAFORM_PROVIDER_API_KEY_SECRET variable - this allows us to benefit from Buildkite's built-in secrets redaction (see doc)
  • The build no longer users the .ci/Makefile or any of its target, but we should keep it around for developers to run this locally (tho we may need to update the secrets path to point to the new ci-vault-path)
  • Some tests are failing at this time in Buildkite, but they're also failing in Jenkins

Related Issues

Motivation and Context

How Has This Been Tested?

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improves code quality but has no user-facing effect)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Readiness Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Porting the acceptance job to Buildkite.
I moved all the logic of the Makefile into a more Buildkite way of
handling secrets (via pre-command) to benefit from secrets redaction.
@nkammah nkammah requested a review from a team as a code owner November 21, 2023 11:03
@nkammah nkammah requested review from tobio and dimuon November 21, 2023 11:04
spec:
repository: elastic/terraform-provider-ec
pipeline_file: ".buildkite/pipeline.yml"
teams:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The below team perms mirror the current GitHub permissions on the repository - this is also reflected in the GH repository RE : https://github.com/elastic/catalog-info/pull/635

This was referenced Nov 21, 2023
Copy link
Contributor

@dimuon dimuon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@tobio tobio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@nkammah nkammah merged commit 29a416c into master Nov 22, 2023
3 of 5 checks passed
@nkammah nkammah deleted the buildkite-pipeline branch November 22, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants