-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup the Release pipeline #740
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For now use the release-nopublish target
dimuon
approved these changes
Nov 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jamietanna
reviewed
Nov 21, 2023
.buildkite/release.yml
Outdated
command: .buildkite/release.sh | ||
agents: | ||
image: "docker.io/library/golang:1.21" | ||
cpu: "8" # The release flow needs that many or hits https://github.com/goreleaser/goreleaser/issues/304 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the right issue number? Add config for number of parallel builds #304
?
3d05307
to
61b49fd
Compare
tobio
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrate the Jenkins Release pipeline to Buildkite.
Notes:
.ci/Makefile
GPG_FINGERPRINT_SECRET
instead ofGPG_FINGERPRINT
so that Buildkite would always redact it and we don't risk leaking it (with a set -x or printenv). I don't think it would affect anyone since this is used only in the CI flow.amd64
at the end which helped with getting the build to succeed as opposed to getting to resource exhaustion - i'm not too sure why..ci/Makefile
should still work to run the flow as a developer instead of ci.Related Issues
Motivation and Context
How Has This Been Tested?
Types of Changes
Readiness Checklist