Migrate private link datasources #659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobio
force-pushed
the
privatelink-datasource
branch
from
4e6c9bd to
eae8b3f
Compare
dimuon
reviewed
May 31, 2023
| _, err := source.readRegionData(model) | ||
| require.ErrorIs(t, err, errUnknownProvider) | ||
| }) | ||
| t.Run("should return a populate state model when accessing a valid region", func(t *testing.T) { |
There was a problem hiding this comment.
Does it make sense to loop over all supported csp providers and regions?
|
I guess we have to update changelog as well. |
dimuon
approved these changes
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #595
Migrates the private link data sources to the plugin framework and re-adds them to the provider data sources.