Utilise the migrate template API when applying changes to the deployment template id #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webfella
approved these changes
Oct 10, 2022
tobio
force-pushed
the
template-migration-api
branch
2 times, most recently
from
6257053 to
4b324d7
Compare
dimuon
reviewed
Oct 10, 2022
| @@ -9,7 +9,16 @@ resource "ec_deployment" "defaults" { | |||
| version = data.ec_stack.latest.version | |||
| deployment_template_id = "%s" | |||
|
|
|||
| elasticsearch {} | |||
| elasticsearch { | |||
There was a problem hiding this comment.
Does it make sense to modify test checks instead? It looks like the acceptance test (TestAccDeployment_basic_defaults_hw) checks updating configuration once the template is changed.
Also shall the acceptance test work as expected without these explicit changes to the sizes? The new template (aws-hot-warm-v2) has size 4g for both hot_content and warm tiers so I guess once the template attribute is set to aws-hot-warm-v2, the tier sizes should change accordingly even without these explicit settings in the configuration.
tobio
force-pushed
the
template-migration-api
branch
from
4e3580d to
e4282ca
Compare
tobio
force-pushed
the
template-migration-api
branch
from
e4282ca to
a189ad6
Compare
dimuon
pushed a commit
to dimuon/terraform-provider-ec
that referenced
this pull request
Feb 2, 2023
…ent template id (elastic#547) * Utilise the migrate template API when applying changes to the deployment template id * Add changelog * Fix acceptance tests * Reset the instance_configuration_id so changes from the migration API are picked up
tobio
added a commit
that referenced
this pull request
Feb 15, 2023
* upstream/master: (28 commits) Update CHANGELOG.md and NOTICE Fix incorrect private link data for Azure eastus (#583) Update CHANGELOG.md and NOTICE Fix typo in GCP PSC datasource documentation (#571) Update CHANGELOG.md and NOTICE fix(deps): update module github.com/go-openapi/runtime to v0.25.0 (#564) Update CHANGELOG.md and NOTICE Utilise the migrate template API when applying changes to the deployment template id (#547) Update CHANGELOG.md and NOTICE fix(deps): update module github.com/hashicorp/terraform-plugin-sdk/v2 to v2.24.1 (#559) Update CHANGELOG.md and NOTICE docs: Add GCP PSC to Traffic Filter argument reference for type (#557) Update CHANGELOG.md and NOTICE chore(deps): update peterjgrainger/action-create-branch action to v2.3.0 (#560) Update CHANGELOG.md and NOTICE fix: remove strategy DiffSuppressFunc (#539) Update CHANGELOG.md and NOTICE fix(deps): update module github.com/stretchr/testify to v1.8.1 (#554) Update CHANGELOG.md and NOTICE Revert "Run acceptance tests in CI against 1.2.9 (#542)" (#553) ...
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use the migrate template API to build the base update request when an existing deployment changes.
deployment_template_id,Related Issues
Fixes #487
Fixes #556
Motivation and Context
This API is purpose built to update deployment options to be compatible with a different template and simplifies the process for migrating deployments between hardware types.
How Has This Been Tested?
Manually, acceptance test, unit tests
Types of Changes
Readiness Checklist