Check type casts to void crashing when casting explicit null values #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobio
force-pushed
the
guard-explicit-nulls
branch
from
017de81 to
df013c8
Compare
|
@tobio can you please check why acceptance tests failed |
|
This test appears to be failing due to hashicorp/terraform-plugin-sdk#1066 and hashicorp/terraform-plugin-sdk#1073 (seem to be duplicates). I've updated the acceptance tests to run against 1.2.9 in CI until the TF issue is fixed. |
tobio
force-pushed
the
guard-explicit-nulls
branch
2 times, most recently
from
cc2811f to
4f9cec1
Compare
tobio
force-pushed
the
guard-explicit-nulls
branch
from
4f9cec1 to
f76d470
Compare
dimuon
pushed a commit
to dimuon/terraform-provider-ec
that referenced
this pull request
Feb 2, 2023
…lastic#534) * Ignore fields explicitly set to null in Kibana resources * Ignore fields explicitly set to null in APM resources * Ignore fields explicitly set to null in ES resources * Ignore fields explicitly set to null in Enterprise Search resources * Ignore fields explicitly set to null in Integrations Server resources * Ignore fields explicitly set to null in observability resources * Ignore fields explicitly set to null in azure private endpoint resources * Changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Repro in the linked issue.
Some fields may be sourced from Terraform variables, if those variables are optional then it's not uncommon to explicitly set fields to null, which the provider should treat as if the field was left unset.
Related Issues
Fixes #522
How Has This Been Tested?
Unit tests
Manually
Types of Changes
Readiness Checklist