ec_deployment: Set snapshot restore strategy to partial on Update
#309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marclop
changed the title
partial on Update
Aran-K
reviewed
May 12, 2021
There was a problem hiding this comment.
I was going to comment on the test failures and then I saw
11:01:46 testing_new.go:63: Error running post-test destroy, there may be dangling resources: exit status 1
11:01:46
11:01:46 Error: found deployment plan errors: 1 error occurred:
11:01:46 * deployment [723e46e3851ddc29d23660da8d03c4c2] - [elasticsearch][f2435f44614342f28023463f313df44e]: caught error: "Plan change failed: Timeout exceeded. Please adjust plan timeout and/or retry plan."
😅
Overall LGTM 
Fixes a bug where the strategy field wasn't set on either of the create or update operations and it made restoring a snapshot on an existing deployment impossible since when `transient.snapshot_restore.strategy` isn't set, the API will make it default to "full", which isn't a valid restoration strategy for snapshots when a deployment has already been created and it's running, for the operation to succeed, "partial" must be used. Signed-off-by: Marc Lopez <[email protected]>
Signed-off-by: Marc Lopez <[email protected]>
Signed-off-by: Marc Lopez <[email protected]>
marclop
force-pushed
the
b/set-partial-snapshot-strategy-when-cluster-is-created
branch
from
d30bd00 to
9f2da50
Compare
Aran-K
approved these changes
May 13, 2021
marclop
deleted the
b/set-partial-snapshot-strategy-when-cluster-is-created
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug where the strategy field wasn't set on either of the create
or update operations and it made restoring a snapshot on an existing
deployment impossible since when
transient.snapshot_restore.strategyisn't set, the API will make it default to "full", which isn't a valid
restoration strategy for snapshots when a deployment has already been
created and it's running, for the operation to succeed, "partial" must
be used.
Related Issues
Closes #249
How Has This Been Tested?
Manual, unit and acceptance tested.
Types of Changes