-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ec_deployment: Add autoscaling support #296
Conversation
Signed-off-by: Marc Lopez <[email protected]>
Signed-off-by: Marc Lopez <[email protected]>
Signed-off-by: Marc Lopez <[email protected]>
Signed-off-by: Marc Lopez <[email protected]>
Signed-off-by: Marc Lopez <[email protected]>
Signed-off-by: Marc Lopez <[email protected]>
Signed-off-by: Marc Lopez <[email protected]>
Signed-off-by: Marc Lopez <[email protected]>
Signed-off-by: Marc Lopez <[email protected]>
Signed-off-by: Marc Lopez <[email protected]>
Signed-off-by: Marc Lopez <[email protected]>
Signed-off-by: Marc Lopez <[email protected]>
ah another question - @marclop , given "autoscaling = true" |
@Kushmaro it's optional at the moment. Since the policy settings can come from the Deployment Template it doesn't make much sense to make it mandatory. |
Agree @marclop :) LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! 👌
Thanks for adding datasource support as well!
Description
Adds support for autoscaling.
The PR has been split in multiple commits to make reviewing easier.
Related Issues
Closes #258
How Has This Been Tested?
Manual, unit and acceptance tests.
Types of Changes