ec_deployment: Avoid unsetting Elasticsearch topology configuration #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handles the `plan.topology.[].elasticsearch` object as a computed block that will be flattened (stored) in the state and expanded when present. This solves the problem where the UI (used to) set these settings at the topology level and the Terraform Provided set them at the Elasticsearch level. It still doesn't allow users to set them at the topology level since that's not the desired behavior, but with after change it will not unset those fields with every plan change anymore, resulting in less disruptive behavior. Signed-off-by: Marc Lopez Rubio <[email protected]>
Signed-off-by: Marc Lopez Rubio <[email protected]>
Signed-off-by: Marc Lopez Rubio <[email protected]>
obierlaire
approved these changes
Aug 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Handles the
plan.topology.[].elasticsearchobject as a computed blockthat will be flattened (stored) in the state and expanded when present.
This solves the problem where the UI (used to) set these settings at the
topology level and the Terraform Provided set them at the Elasticsearch
level. It still doesn't allow users to set them at the topology level
since that's not the desired behavior, but with after change it will not
unset those fields with every plan change anymore, resulting in less
disruptive behavior.
Related Issues
Resolves #214
Types of Changes