Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elasticsearch user config is not discovered #214

Closed
wgebis opened this issue Dec 18, 2020 · 5 comments · Fixed by #361
Closed

Elasticsearch user config is not discovered #214

wgebis opened this issue Dec 18, 2020 · 5 comments · Fixed by #361
Assignees
Labels
bug Something isn't working Known issue Known issue that is well documented

Comments

@wgebis
Copy link

wgebis commented Dec 18, 2020

Expected Behavior

According to docs, elasticsearch config section should be honoured and should be pushable to ec_deployment.

Current Behavior

When config is defined under UI it is not handled by the TF resource. Kibana config section works as expected.

Possible Solution

Adding support for elasticsearch config handling.

Steps to Reproduce

  1. Create elasticsearch config under Edit / User setting overwrites
  2. Run terraform plan/apply
  3. Changes are not detected.

Your Environment

  • Version used: 0.1.0-beta
  • ES version: 7.10.1
@zonArt
Copy link

zonArt commented Dec 22, 2020

Experimented the same issue. And to add some context, when trying to push a faulty configuration my deployment just failed meaning in a way it's aware it needs to change something but when wrong refuses to do it. Once I've corrected my config block, it tried to redeploy ES and succeeded, but when I looked to the config nothing changed. Now that I run terraform again it just tells me it's ok.

@Kushmaro
Copy link
Collaborator

Thanks @zonArt @wgebis , this is actually a known issue that occurs due to our API model having two config sections - one per elasticsearch topology element, and one per all elasticsearch component.

IIRC, it's something we're trying to resolve by having the UI present & migrate topology specific settings to the global elasticsearch settings, thus, everything will be displayed and behave correctly.

I'll update when this is resolved on the Cloud UI front. For the terraform provider, we think the correct behaviour is having a single config section to apply to all elasticsearch elements.

Do feel free to elaborate on any use cases where you think this may not be the desired case.

@Kushmaro Kushmaro added the bug Something isn't working label Dec 27, 2020
@marclop marclop added the wontfix This will not be worked on label Jan 4, 2021
@wgebis
Copy link
Author

wgebis commented Jan 7, 2021

@Kushmaro Thanks.
I wonder, if I define the config for all elasticsearch component, every elasticsearch instance will have that config? If I push elasticsearch config via current ec provider, where I will be able to see it on the UI?

@Kushmaro
Copy link
Collaborator

@wgebis if you push a config using the provider, it goes to the "global" space which applies to all elasticsearch instances (/cc @marclop to keep me honest )

You will (currently) not be able to see it in the UI (but the config will be applied). That is the internal issue I've mentioned we're trying to resolve.

@wgebis
Copy link
Author

wgebis commented Jan 20, 2021

@Kushmaro So I will handle it in that way currently. Look forward to able to view the config on UI as well.
Thanks!

@marclop marclop pinned this issue Jan 21, 2021
@marclop marclop added the Known issue Known issue that is well documented label Jul 26, 2021
@marclop marclop unpinned this issue Jul 26, 2021
@marclop marclop removed the wontfix This will not be worked on label Aug 31, 2021
@marclop marclop self-assigned this Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Known issue Known issue that is well documented
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants