ec_extension: implement extension resource

[snowhork]

This PR is for #102.
Our team want to manage extension with terraform.

Please review.

Description

This PR is new resource for extension.

How Has This Been Tested?

Execute commands below.

$ make install
$ cd examples/extension
$ terraform init
$ terraform apply

And then, I have checked the created extension.

Next, I have changed terraform file (changed description) and applied, then I have watched the extension description changed.

Next, I have removed ec_extension in terraform file and applied, then I have watched the extension removed.

Types of Changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Refactoring (improves code quality but has no user-facing effect)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation

Readiness Checklist

• [x ] My code follows the code style of this project
• My change requires a change to the documentation
• I have updated the documentation accordingly
• I have added tests to cover my changes
• All new and existing tests passed

[elasticmachine]

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

[cla-checker-service]

💚 CLA has been signed

[snowhork]

@marclop Could you review this PR?

[marclop]

Thank you for your contribution, I appreciate the time you put in the development of this new resource.

I left a few comments on code structure and on the terraform flow.

Additionally there's two important things that are missing in this pull request before it can be merged; resource docs and acceptance tests, both are required before we can mark this as done.

The acceptance tests are underway ec/acc, three acceptance tests should be added:

• Test 1 with the download_url set to a location where a file exists.
• Test 2 with a bundle creation without any file_path and file_hash set. This test should a also test update changes (description, etc.)
• Test 3 with a bundle creation with a file_path and file_hash set. This test should also test the behavior where file_hash changes and the file is re-uploaded.

Under the docs folder (docs/resources) a new ec_extension.md file should be added with a similar format to the other existing resources. It should describe what this resource does, its arguments with their default values and attributes.

Let me know if you need any help.

[marclop]

I'm not sure what you meant in this sentence, it should be changed to something that guides the user how to create an actual extension, possibly to the Elasticsearch docs?

[snowhork]

fixed by a55feb8. Please check this README?

[marclop]

We might want to change this and the folder name to extension_bundle since it doesn't cover the plugin extension type.

[snowhork]

changed by a55feb8. (Sorry, I can't check plugin type extension in my environment.)

[snowhork]

Thank you very much for your review. I'll check and fix.

[marclop]

Some additional comments on a few things I missed on the initial review.

[snowhork]

@marclop Thanks for your support. I'm writing acc test, and I have a question.

What should I set download_url ? Do you have any valid url for example?

[marclop]

@snowhork I'm trying to get a download_url we can use in the acceptance tests that doesn't get accidentally removed, I'll let you know once I have that.

[marclop]

Jenkins test this please.

[marclop]

@snowhork you can use this link to obtain the analysis-icu plugin for the 7.10.1 version:

• https://artifacts.elastic.co/downloads/elasticsearch-plugins/analysis-icu/analysis-icu-7.10.1.zip

You could change it to any version that's published by changing the 7.10.1 suffix to another version:

https://artifacts.elastic.co/downloads/elasticsearch-plugins/analysis-icu/analysis-icu-$VERSION.zip

[snowhork]

@marclop Thank you very much. I will fix soon.

[snowhork]

@marclop I have added acc tests. please review.

[marclop]

last nits, otherwise looks good.

[marclop]

@nrichers @alaudazzi can you have a look at the /docs files see if you folks would like anything to be changed before we merge it?

@karencfv do you want to give it a lass pass?

[marclop]

Jenkins test this please

[karencfv]

Looking good! Just left a few very minor comments, thanks for working on this @snowhork

[karencfv]

Jenkins test this please

[marclop]

Looks good to me.