Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deploymentapi: Add new CRUD APIs for extensions #269

Merged
merged 2 commits into from
Jan 6, 2021
Merged

deploymentapi: Add new CRUD APIs for extensions #269

merged 2 commits into from
Jan 6, 2021

Conversation

karencfv
Copy link
Contributor

@karencfv karencfv commented Jan 6, 2021

Description

New APIs for all deployment extension CRUD APIs

Related Issues

Related: elastic/terraform-provider-ec#216

Types of Changes

  • New feature (non-breaking change which adds functionality)

Readiness Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@karencfv karencfv added the enhancement New feature or request label Jan 6, 2021
@karencfv karencfv requested a review from a team as a code owner January 6, 2021 04:00
@karencfv karencfv self-assigned this Jan 6, 2021
marclop
marclop approved these changes Jan 6, 2021
View reviewed changes
Copy link
Collaborator

@marclop marclop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

pkg/api/deploymentapi/extensionapi/create_test.go Show resolved Hide resolved
@karencfv karencfv merged commit 507cc61 into elastic:master Jan 6, 2021
@karencfv karencfv deleted the extension-apis branch January 6, 2021 21:22
@karencfv karencfv mentioned this pull request Jan 13, 2021
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marclop marclop marclop approved these changes

Assignees

@karencfv karencfv

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@karencfv @marclop