Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add step duration to step/end #304

Merged
merged 3 commits into from
Jun 9, 2021

Conversation

vigneshshanmugam
Copy link
Member

@vigneshshanmugam vigneshshanmugam commented Jun 8, 2021

  • fix Add step duration as an indexed field #302
  • Adds the step duration info in us for all step/end event under step object.
  • Gets rid of start/end in payload as we rely on step info for querying all network events.

@vigneshshanmugam vigneshshanmugam requested a review from andrewvc June 8, 2021 19:35
@apmmachine
Copy link

apmmachine commented Jun 8, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #304 updated

  • Start Time: 2021-06-08T22:07:45.057+0000

  • Duration: 13 min 52 sec

  • Commit: eb84ffe

Test stats 🧪

Test Results
Failed 0
Passed 108
Skipped 0
Total 108

Trends 🧪

Image of Build Times

Image of Tests

src/reporters/json.ts Show resolved Hide resolved
@vigneshshanmugam vigneshshanmugam requested a review from andrewvc June 8, 2021 20:53
Copy link
Contributor

@andrewvc andrewvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure the reported numbers are not micros. In one test run I got 0.05044099999940954 as a value.

Invoked with npm run build; node dist/cli.js examples/todos/ --rich-events | grep step/end | jq .step

I'm pretty sure the values are actually fractional seconds

@vigneshshanmugam
Copy link
Member Author

@andrewvc 🤦🏽 moment here, Yes it is indeed denoting seconds -

}' ${status} (${renderDuration((end - start) * 1000)} ms)`;
.

@vigneshshanmugam vigneshshanmugam requested a review from andrewvc June 8, 2021 22:08
Copy link
Contributor

@andrewvc andrewvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add step duration as an indexed field
3 participants