-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add step duration to step/end #304
feat: add step duration to step/end #304
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm pretty sure the reported numbers are not micros. In one test run I got 0.05044099999940954 as a value.
Invoked with npm run build; node dist/cli.js examples/todos/ --rich-events | grep step/end | jq .step
I'm pretty sure the values are actually fractional seconds
@andrewvc 🤦🏽 moment here, Yes it is indeed denoting seconds - synthetics/src/reporters/base.ts Line 86 in e0f7638
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
us
for allstep/end
event under step object.