Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose driver types from the agent #239

Merged
merged 1 commit into from
Mar 10, 2021

Conversation

vigneshshanmugam
Copy link
Member

@vigneshshanmugam vigneshshanmugam commented Mar 9, 2021

  • Solves the problem specified in Improve imports/deps to use playwright-core transitively and Improve Example naming #158
  • Exposes all of the driver types that could be used from the suites
  • It solves the problem of users needing to import playwright-core or playwright-* for using types and eventually run in to problems of version mismatch.
  • Once we add support for multiple browsers, we would expose the types from playwright-core instead and rest would look the same

@@ -5,7 +5,6 @@
"scripts": {},
"license": "MIT",
"dependencies": {
"@elastic/synthetics": "*",
"playwright-core": "=1.6.2"
"@elastic/synthetics": "file:../../"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will change once we merge and release a new version where types would become available.

@apmmachine
Copy link

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #239 opened

  • Start Time: 2021-03-09T23:50:13.524+0000

  • Duration: 18 min 40 sec

  • Commit: e319ce2

Test stats 🧪

Test Results
Failed 0
Passed 73
Skipped 0
Total 73

Trends 🧪

Image of Build Times

Image of Tests

Copy link
Contributor

@andrewvc andrewvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vigneshshanmugam vigneshshanmugam merged commit d194eb3 into elastic:master Mar 10, 2021
@vigneshshanmugam vigneshshanmugam deleted the fix-deps branch March 10, 2021 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants