Added start and stop scripts #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leemthompo
approved these changes
Oct 14, 2024
Co-authored-by: Liam Thompson <[email protected]>
Co-authored-by: Liam Thompson <[email protected]>
Co-authored-by: Liam Thompson <[email protected]>
|
Thanks @leemthompo for the review! |
pquentin
approved these changes
Oct 15, 2024
start-local.sh
Outdated
| @@ -475,6 +536,7 @@ print_steps() { | |||
| echo "- Generated random passwords" | |||
| echo "- Created a .env file with settings" | |||
| echo "- Created a docker-compose.yml file" | |||
| echo "- Created start/stop/uninstall commands" | |||
There was a problem hiding this comment.
Small suggestion on the wording. I'm not sure of it, just thinking out loud here.
Suggested change
| echo "- Created start/stop/uninstall commands" | |
| echo "- Created start.sh/stop.sh/uninstall.sh scripts" |
There was a problem hiding this comment.
I don't think these details are important. The message is to inform the user about the actions and the fact that there are 3 commands that can be used.
start-local.sh
Outdated
Comment on lines
536
to
539
| echo "- Generated random passwords" | ||
| echo "- Created a .env file with settings" | ||
| echo "- Created a docker-compose.yml file" | ||
| echo "- Created start/stop/uninstall commands" |
There was a problem hiding this comment.
What are your thoughts on using indentation to clarify the files that go into elastic-start-local?
- Generated random passwords
- Created the elastic-start-local folder with:
- .env file with settings
- docker-compose.yml
- start.sh/stop.sh/uninstall.sh scripts
- Running docker compose up --wait
|
Thanks @pquentin for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal for adding a
start.shandstop.shscripts to facilitate the start and the stop of the docker services. This script can be used after thestart-localinstallation, e.g. after a reboot. Using these scripts the user do not need to interact with docker commands anymore for start, stop or re-start Elasticsearch and Kibana.