-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: link to new APM book #1850
Conversation
# Conflicts: # docs/en/install-upgrade/upgrading-stack.asciidoc
* {ref}/docker.html[Install {es} with Docker] | ||
* {apm-server-ref}/running-on-docker.html[Running APM Server on Docker] | ||
* {auditbeat-ref}/running-on-docker.html[Running {auditbeat} on Docker] | ||
* {filebeat-ref}/running-on-docker.html[Running {filebeat} on Docker] | ||
* {heartbeat-ref}/running-on-docker.html[Running {heartbeat} on Docker] | ||
* {kibana-ref}/docker.html[Running {kib} on Docker] | ||
* {logstash-ref}/docker.html[Running {ls} on Docker] | ||
* {metricbeat-ref}/running-on-docker.html[Running {metricbeat} on Docker] | ||
* {packetbeat-ref}/running-on-docker.html[Running {packetbeat} on Docker] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewers -- this is a change I'd like feedback on. Link to docs: https://www.elastic.co/guide/en/elastic-stack-get-started/current/get-started-docker.html#_product_specific_instructions_for_docker
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Getting started topic seems to focus on Elasticsearch, Kibana, and Beats. So maybe we just list the links for Elasticsearch, Kibana, and the Elastic Agent? It looks like the elastic-agent-container.html
file hasn't been moved yet to the Observability guide.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the elastic-agent-container.html file hasn't been moved yet to the Observability guide.
I'm not planning to move to elastic-agent-container.html to the obs guide because the docs are needed for other use cases (not just observability).
I'm on the fence about removing these links because I think it's still hard for users to find all the content they need about running on containers (though I agree that Beats aren't really for "getting started"). We could group them under a section called "Legacy shippers"?
I'd be curious to hear what @lcawl thinks about the related links.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just one minor comment.
* {ref}/docker.html[Install {es} with Docker] | ||
* {apm-server-ref}/running-on-docker.html[Running APM Server on Docker] | ||
* {auditbeat-ref}/running-on-docker.html[Running {auditbeat} on Docker] | ||
* {filebeat-ref}/running-on-docker.html[Running {filebeat} on Docker] | ||
* {heartbeat-ref}/running-on-docker.html[Running {heartbeat} on Docker] | ||
* {kibana-ref}/docker.html[Running {kib} on Docker] | ||
* {logstash-ref}/docker.html[Running {ls} on Docker] | ||
* {metricbeat-ref}/running-on-docker.html[Running {metricbeat} on Docker] | ||
* {packetbeat-ref}/running-on-docker.html[Running {packetbeat} on Docker] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Getting started topic seems to focus on Elasticsearch, Kibana, and Beats. So maybe we just list the links for Elasticsearch, Kibana, and the Elastic Agent? It looks like the elastic-agent-container.html
file hasn't been moved yet to the Observability guide.
@elasticmachine, run elasticsearch-ci/docs |
1 similar comment
@elasticmachine, run elasticsearch-ci/docs |
This is failing and I'm not sure why. Took a wild guess and opened elastic/docs#2272. |
@elasticmachine, run elasticsearch-ci/docs |
# Conflicts: # docs/en/glossary/glossary.asciidoc # docs/en/install-upgrade/breaking.asciidoc
Sorry, the blank spaces at the end of lines really clutter the diff up.