Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: link to new APM book #1850

Merged
merged 5 commits into from
Oct 29, 2021
Merged

Conversation

bmorelli25
Copy link
Member

@bmorelli25 bmorelli25 commented Oct 19, 2021

Sorry, the blank spaces at the end of lines really clutter the diff up.

# Conflicts:
#	docs/en/install-upgrade/upgrading-stack.asciidoc
Comment on lines 254 to -262
* {ref}/docker.html[Install {es} with Docker]
* {apm-server-ref}/running-on-docker.html[Running APM Server on Docker]
* {auditbeat-ref}/running-on-docker.html[Running {auditbeat} on Docker]
* {filebeat-ref}/running-on-docker.html[Running {filebeat} on Docker]
* {heartbeat-ref}/running-on-docker.html[Running {heartbeat} on Docker]
* {kibana-ref}/docker.html[Running {kib} on Docker]
* {logstash-ref}/docker.html[Running {ls} on Docker]
* {metricbeat-ref}/running-on-docker.html[Running {metricbeat} on Docker]
* {packetbeat-ref}/running-on-docker.html[Running {packetbeat} on Docker]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Getting started topic seems to focus on Elasticsearch, Kibana, and Beats. So maybe we just list the links for Elasticsearch, Kibana, and the Elastic Agent? It looks like the elastic-agent-container.html file hasn't been moved yet to the Observability guide.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the elastic-agent-container.html file hasn't been moved yet to the Observability guide.

I'm not planning to move to elastic-agent-container.html to the obs guide because the docs are needed for other use cases (not just observability).

I'm on the fence about removing these links because I think it's still hard for users to find all the content they need about running on containers (though I agree that Beats aren't really for "getting started"). We could group them under a section called "Legacy shippers"?

I'd be curious to hear what @lcawl thinks about the related links.

Copy link
Contributor

@EamonnTP EamonnTP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just one minor comment.

Comment on lines 254 to -262
* {ref}/docker.html[Install {es} with Docker]
* {apm-server-ref}/running-on-docker.html[Running APM Server on Docker]
* {auditbeat-ref}/running-on-docker.html[Running {auditbeat} on Docker]
* {filebeat-ref}/running-on-docker.html[Running {filebeat} on Docker]
* {heartbeat-ref}/running-on-docker.html[Running {heartbeat} on Docker]
* {kibana-ref}/docker.html[Running {kib} on Docker]
* {logstash-ref}/docker.html[Running {ls} on Docker]
* {metricbeat-ref}/running-on-docker.html[Running {metricbeat} on Docker]
* {packetbeat-ref}/running-on-docker.html[Running {packetbeat} on Docker]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Getting started topic seems to focus on Elasticsearch, Kibana, and Beats. So maybe we just list the links for Elasticsearch, Kibana, and the Elastic Agent? It looks like the elastic-agent-container.html file hasn't been moved yet to the Observability guide.

@bmorelli25
Copy link
Member Author

@elasticmachine, run elasticsearch-ci/docs

1 similar comment
@bmorelli25
Copy link
Member Author

@elasticmachine, run elasticsearch-ci/docs

@bmorelli25
Copy link
Member Author

This is failing and I'm not sure why. Took a wild guess and opened elastic/docs#2272.

@bmorelli25
Copy link
Member Author

@elasticmachine, run elasticsearch-ci/docs

@bmorelli25 bmorelli25 merged commit 2a4e66d into elastic:main Oct 29, 2021
@bmorelli25 bmorelli25 deleted the update-apm-links branch October 29, 2021 23:02
bmorelli25 added a commit to bmorelli25/stack-docs that referenced this pull request Oct 29, 2021
bmorelli25 added a commit to bmorelli25/stack-docs that referenced this pull request Oct 29, 2021
# Conflicts:
#	docs/en/glossary/glossary.asciidoc
#	docs/en/install-upgrade/breaking.asciidoc
bmorelli25 added a commit that referenced this pull request Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants