Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Add concept of trained models #1391

Merged
merged 4 commits into from
Oct 2, 2020
Merged

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Oct 1, 2020

@lcawl lcawl force-pushed the model-management branch from c976e68 to 85263b1 Compare October 1, 2020 21:55
@lcawl lcawl marked this pull request as ready for review October 1, 2020 22:55
@lcawl
Copy link
Contributor Author

lcawl commented Oct 1, 2020

@darnautov I noticed that the Kibana model management app says "Total inference trained models". Should we drop "inference" from that title to align with the API changes @benwtrent made?

@lcawl lcawl requested review from benwtrent and removed request for benskelker October 1, 2020 23:00
@darnautov
Copy link
Contributor

@darnautov I noticed that the Kibana model management app says "Total inference trained models". Should we drop "inference" from that title to align with the API changes @benwtrent made?

@lcawl yes, makes sense, I'll create a PR 👍

Copy link
Contributor

@szabosteve szabosteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment, otherwise LGTM! Thanks!

@lcawl lcawl merged commit 8666dbd into elastic:master Oct 2, 2020
@lcawl lcawl deleted the model-management branch October 2, 2020 17:18
lcawl added a commit that referenced this pull request Oct 2, 2020
Co-authored-by: István Zoltán Szabó <[email protected]>
Co-authored-by: Benjamin Trent <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants