Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Update snapshot retention details #1047

Merged
merged 5 commits into from
May 13, 2020

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented May 7, 2020

This PR updates the "Model snapshots" page with details about how long snapshots are retained. It also includes minor improvements to other sections of that page.

Related to elastic/elasticsearch#52150

Preview: http://stack-docs_1047.docs-preview.app.elstc.co/guide/en/machine-learning/master/ml-model-snapshots.html

@lcawl lcawl requested a review from szabosteve May 7, 2020 17:48
Copy link
Contributor

@szabosteve szabosteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small remark, otherwise LGTM.

cluster. The amount of time necessary to save these snapshots is proportional to
the size of the model in memory. By default, snapshots are captured
approximately every 3 to 4 hours. You can change this interval
(`background_persist_interval`) when you create or update a job.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we link to the APIs where the users can change the interval?

Copy link
Contributor

@droberts195 droberts195 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lcawl lcawl merged commit 5baaa85 into elastic:master May 13, 2020
@lcawl lcawl deleted the snapshot-retention branch May 13, 2020 16:18
lcawl added a commit that referenced this pull request May 13, 2020
lcawl added a commit that referenced this pull request May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants