Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configuring seed #3

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Configuring seed #3

merged 1 commit into from
Jan 31, 2024

Conversation

tiansivive
Copy link
Contributor

@tiansivive tiansivive commented Jan 31, 2024 •
edited
Loading

You can now pass in a seed to generate the stable data

data-gen.mov

nkhristinin
nkhristinin approved these changes Jan 31, 2024
View reviewed changes
Copy link
Collaborator

@nkhristinin nkhristinin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

But saw, some diff only about formating.

There prettier config, but maybe it not working, for me or you properly.

Maybe good idea in the future to add prettier to precommit hook or something

@tiansivive tiansivive merged commit b30a9be into main Jan 31, 2024
1 check passed
hop-dev pushed a commit to hop-dev/security-documents-generator that referenced this pull request Oct 29, 2024
@tiansivive
Merge pull request elastic#3 from elastic/seed-config
79ea773 
Configuring seed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkhristinin nkhristinin nkhristinin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tiansivive @nkhristinin