Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Download prebuilt rules (7.13 addendum) #777

Merged
merged 2 commits into from
Jun 30, 2021

Conversation

jmikell821
Copy link
Contributor

@jmikell821 jmikell821 commented Jun 29, 2021

Addresses this comment.
Related: #720

Preview here.

@jmikell821
Copy link
Contributor Author

Hi @rw-access - please review this PR (preview link is in the first comment) and let me know if I need to make any further adjustments. I understand that for 7.14, we'll have to revise slightly since Integrations is moving to its own section in the new navigation.

Copy link
Contributor

@rw-access rw-access left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great, thanks @jmikell821! will this change be made to the 7.13 docs or 7.14 docs?

for some reason the pictures render a little fuzzy for me, but look fine when I open in a new tab.

Copy link
Contributor

@nastasha-solomon nastasha-solomon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jmikell821
Copy link
Contributor Author

jmikell821 commented Jun 30, 2021

this looks great, thanks @jmikell821! will this change be made to the 7.13 docs or 7.14 docs?

for some reason the pictures render a little fuzzy for me, but look fine when I open in a new tab.

Hey @rw-access, if the images look like this on your end, that's how the resolution renders unfortunately with our docs.
2021-06-30_10-30-02

We're hoping images will be a bit clearer when we launch the new docs system. These changes will be backported to 7.13 and 7.x, so it'll appear in 7.14 as well.

@jmikell821 jmikell821 merged commit 4398431 into master Jun 30, 2021
jmikell821 added a commit to jmikell821/security-docs that referenced this pull request Jun 30, 2021
jmikell821 added a commit to jmikell821/security-docs that referenced this pull request Jun 30, 2021
@nastasha-solomon nastasha-solomon deleted the prebuilt-rules-fix-7.13 branch October 26, 2022 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants