Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Fleet and Endpoint Security require a Transform, appropriate configuration is needed #693

Merged
merged 4 commits into from
May 24, 2021
Merged

[DOCS] Fleet and Endpoint Security require a Transform, appropriate configuration is needed #693

merged 4 commits into from
May 24, 2021

Conversation

nastasha-solomon
Copy link
Contributor

@nastasha-solomon nastasha-solomon commented May 20, 2021 •
edited
Loading

Addresses #608.

Preview here.

@nastasha-solomon nastasha-solomon self-assigned this May 20, 2021
kevinlog
kevinlog approved these changes May 20, 2021
View reviewed changes
Copy link
Contributor

@kevinlog kevinlog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! Thanks!

jmikell821
jmikell821 reviewed May 24, 2021
View reviewed changes
Copy link
Contributor

@jmikell821 jmikell821 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few suggestions. Otherwise, LGTM.

docs/getting-started/sec-app-requirements.asciidoc Outdated Show resolved Hide resolved
docs/getting-started/sec-app-requirements.asciidoc Outdated Show resolved Hide resolved
docs/getting-started/sec-app-requirements.asciidoc Show resolved Hide resolved
@nastasha-solomon nastasha-solomon merged commit 3b96d93 into master May 24, 2021
nastasha-solomon added a commit to nastasha-solomon/security-docs that referenced this pull request May 24, 2021
@nastasha-solomon
[DOCS] Fleet and Endpoint Security require a Transform, appropriate c…
921b6ee 
…onfiguration is needed (elastic#693)

* Adding section for required node roles.

* Adding missing article.

* Added Janeen's feedback.
@nastasha-solomon nastasha-solomon mentioned this pull request May 24, 2021
Merged
nastasha-solomon added a commit to nastasha-solomon/security-docs that referenced this pull request May 24, 2021
@nastasha-solomon
[DOCS] Fleet and Endpoint Security require a Transform, appropriate c…
cc95cd5 
…onfiguration is needed (elastic#693)

* Adding section for required node roles.

* Adding missing article.

* Added Janeen's feedback.
@nastasha-solomon nastasha-solomon mentioned this pull request May 24, 2021
Merged
@jmikell821 jmikell821 mentioned this pull request May 24, 2021
Closed
nastasha-solomon added a commit that referenced this pull request May 24, 2021
@nastasha-solomon
[DOCS] Fleet and Endpoint Security require a Transform, appropriate c…
8c1abd3 
…onfiguration is needed (#693) (#699)

* Adding section for required node roles.

* Adding missing article.

* Added Janeen's feedback.
nastasha-solomon added a commit that referenced this pull request May 24, 2021
@nastasha-solomon
[DOCS] Fleet and Endpoint Security require a Transform, appropriate c…
c5dc3dd 
…onfiguration is needed (#693) (#700)

* Adding section for required node roles.

* Adding missing article.

* Added Janeen's feedback.
@nastasha-solomon nastasha-solomon deleted the issue-608-add-node-roles-config branch August 18, 2021 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmikell821 jmikell821 jmikell821 left review comments

@kevinlog kevinlog kevinlog approved these changes

Assignees

@nastasha-solomon nastasha-solomon

Labels
Team: Docs v7.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nastasha-solomon @kevinlog @jmikell821