-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Updating "Manage detection alerts" topic #666
Merged
nastasha-solomon
merged 25 commits into
master
from
issue-664-update-managing-detection-alerts-topic
May 25, 2021
Merged
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
7b6e59d
Updating topic title.
nastasha-solomon 8def142
Merge branch 'master' into issue-664-update-managing-detection-alerts…
nastasha-solomon 6a1ff99
Merge branch 'master' into issue-664-update-managing-detection-alerts…
nastasha-solomon 530e739
Expanded the section about vieiwing and filtering detection alerts.
nastasha-solomon a329e56
Fixed minor typos.
nastasha-solomon ad0df32
Updated section for customizing the Alerts table and added a section …
nastasha-solomon a67798e
Added float tag before the Customize the Alerts table section and fix…
nastasha-solomon f758ba0
Added images and started the view alert details section.
nastasha-solomon 88a8b2c
Minor updates to drafted section.
nastasha-solomon 89b32c6
Fixed minor issues.
nastasha-solomon c86ec95
Merge branch 'master' into issue-664-update-managing-detection-alerts…
nastasha-solomon 902064f
Commiting drafted changes. Additional changes incoming.
nastasha-solomon 4d82784
Incorporated additional comments from Ece.
nastasha-solomon dffc4bf
Removed duplicate text in description of Threat Intel tab.
nastasha-solomon 9c07fb6
Re-adding feedback from Ece.
nastasha-solomon 5e526a9
Merge branch 'master' into issue-664-update-managing-detection-alerts…
nastasha-solomon 2a428d4
Incorporated Ece's latest suggestion.
nastasha-solomon 508b8fd
Adding missing commas.
nastasha-solomon 0a695f8
Incorporating feedback from Janeen,
nastasha-solomon 359914e
Minor typos.
nastasha-solomon 5cb41c3
Updated screenshot showing Detections page.
nastasha-solomon 4094b03
Merge branch 'master' into issue-664-update-managing-detection-alerts…
nastasha-solomon e57a028
Merge branch 'master' into issue-664-update-managing-detection-alerts…
nastasha-solomon 1033b26
Merge branch 'master' into issue-664-update-managing-detection-alerts…
jmikell821 49027c8
Updates to new prebuilt rules integration
jmikell821 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, IMO, we don't need this many arrows. I think we should just draw a box around the additional filter options and maybe the stack by drop-down. WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree that we don't need as many arrows. Initially, I figured it'd be useful to include a screenshot that highlighted all the components listed. However, because of where the image is placed (after the last bullet), it might make more sense to only highlight the Additional Filters dropdown. That said, if we want to emphasize that the Trend histogram can be filtered too, it'd make sense to draw a box around the Stack by dropdown as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing the arrows and only highlighting the Additional Filters dropdown to resolve this comment.