-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Rules updates (7.12) #582
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes to threshold aggs.
Preview links:
|
jmikell821
requested review from
MikePaquette,
dontcallmesherryli and
nastasha-solomon
March 24, 2021 19:31
nastasha-solomon
approved these changes
Mar 24, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall! Only suggested two minor edits--and they might ultimately be unnecessary.
@jmikell821 thanks for getting these changes in! |
MikePaquette
approved these changes
Mar 25, 2021
dontcallmesherryli
approved these changes
Mar 26, 2021
jmikell821
added a commit
to jmikell821/security-docs
that referenced
this pull request
Mar 26, 2021
jmikell821
added a commit
to jmikell821/security-docs
that referenced
this pull request
Mar 26, 2021
jmikell821
added a commit
that referenced
this pull request
Mar 26, 2021
jmikell821
added a commit
that referenced
this pull request
Mar 26, 2021
This was referenced Mar 26, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: