-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds note about DaemonSet support #5675
Conversation
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
🚀 Built elastic-dot-co-docs-preview-docs successfully!
|
🚀 Built elastic-dot-co-docs-preview-docs successfully!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some quick fixes — can approve once you commit
docs/release-notes/8.10.asciidoc
Outdated
@@ -86,7 +86,7 @@ There are no user-facing changes in 8.10.2. | |||
[discrete] | |||
[[breaking-changes-8.10.0]] | |||
==== Breaking changes | |||
There are no breaking changes in 8.10.0. | |||
* Deploying Elastic Defend as a DaemonSet in Kubernetes is no longer supported. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noticed this -- so was this removal of support backported to 8.10? Typically I'd expect the previous versions to support something, and then in the current version we stop supporting it.
But if we're removing support even from previous versions, then we'd need to update ALL the release notes files for all the versions that we no longer support (so make the same change to 8.11.asciidoc, 8.12.asciidoc, etc.). And then update all of those files in each one of the version branches affected. This will probably goof up Mergify at some point, since it's not really set up for complex stuff.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The removal of support was in 8.10, but wasn't documented at the time. That's why I think it makes sense to just add it to the 8.10 RNs. Nothing about this feature changed in the 8.11 etc. versions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha, makes sense. Thanks!
Co-authored-by: Joe Peeples <[email protected]>
Co-authored-by: Joe Peeples <[email protected]>
Co-authored-by: Joe Peeples <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me but to be technically 💯 accurate.
elastic defend cannot be deployed as part of elastic agent DaemonSet in Kubernetes
* Adds note about DaemonSet support * Update docs/getting-started/install-endpoint.asciidoc Co-authored-by: Joe Peeples <[email protected]> * Update docs/release-notes/8.10.asciidoc Co-authored-by: Joe Peeples <[email protected]> * Update docs/serverless/edr-install-config/install-elastic-defend.mdx Co-authored-by: Joe Peeples <[email protected]> * updates wording --------- Co-authored-by: Joe Peeples <[email protected]> (cherry picked from commit a662e9e) # Conflicts: # docs/serverless/edr-install-config/install-elastic-defend.mdx
* Adds note about DaemonSet support * Update docs/getting-started/install-endpoint.asciidoc Co-authored-by: Joe Peeples <[email protected]> * Update docs/release-notes/8.10.asciidoc Co-authored-by: Joe Peeples <[email protected]> * Update docs/serverless/edr-install-config/install-elastic-defend.mdx Co-authored-by: Joe Peeples <[email protected]> * updates wording --------- Co-authored-by: Joe Peeples <[email protected]> (cherry picked from commit a662e9e) # Conflicts: # docs/serverless/edr-install-config/install-elastic-defend.mdx
* Adds note about DaemonSet support * Update docs/getting-started/install-endpoint.asciidoc Co-authored-by: Joe Peeples <[email protected]> * Update docs/release-notes/8.10.asciidoc Co-authored-by: Joe Peeples <[email protected]> * Update docs/serverless/edr-install-config/install-elastic-defend.mdx Co-authored-by: Joe Peeples <[email protected]> * updates wording --------- Co-authored-by: Joe Peeples <[email protected]> (cherry picked from commit a662e9e) # Conflicts: # docs/serverless/edr-install-config/install-elastic-defend.mdx
* Adds note about DaemonSet support * Update docs/getting-started/install-endpoint.asciidoc Co-authored-by: Joe Peeples <[email protected]> * Update docs/release-notes/8.10.asciidoc Co-authored-by: Joe Peeples <[email protected]> * Update docs/serverless/edr-install-config/install-elastic-defend.mdx Co-authored-by: Joe Peeples <[email protected]> * updates wording --------- Co-authored-by: Joe Peeples <[email protected]> (cherry picked from commit a662e9e) # Conflicts: # docs/serverless/edr-install-config/install-elastic-defend.mdx
* Adds note about DaemonSet support * Update docs/getting-started/install-endpoint.asciidoc Co-authored-by: Joe Peeples <[email protected]> * Update docs/release-notes/8.10.asciidoc Co-authored-by: Joe Peeples <[email protected]> * Update docs/serverless/edr-install-config/install-elastic-defend.mdx Co-authored-by: Joe Peeples <[email protected]> * updates wording --------- Co-authored-by: Joe Peeples <[email protected]> (cherry picked from commit a662e9e) # Conflicts: # docs/serverless/edr-install-config/install-elastic-defend.mdx
* Adds note about DaemonSet support * Update docs/getting-started/install-endpoint.asciidoc Co-authored-by: Joe Peeples <[email protected]> * Update docs/release-notes/8.10.asciidoc Co-authored-by: Joe Peeples <[email protected]> * Update docs/serverless/edr-install-config/install-elastic-defend.mdx Co-authored-by: Joe Peeples <[email protected]> * updates wording --------- Co-authored-by: Joe Peeples <[email protected]> (cherry picked from commit a662e9e) # Conflicts: # docs/serverless/edr-install-config/install-elastic-defend.mdx
* Adds note about DaemonSet support (#5675) * Adds note about DaemonSet support * Update docs/getting-started/install-endpoint.asciidoc Co-authored-by: Joe Peeples <[email protected]> * Update docs/release-notes/8.10.asciidoc Co-authored-by: Joe Peeples <[email protected]> * Update docs/serverless/edr-install-config/install-elastic-defend.mdx Co-authored-by: Joe Peeples <[email protected]> * updates wording --------- Co-authored-by: Joe Peeples <[email protected]> (cherry picked from commit a662e9e) # Conflicts: # docs/serverless/edr-install-config/install-elastic-defend.mdx * Delete docs/serverless directory and its contents --------- Co-authored-by: Benjamin Ironside Goldstein <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Adds note about DaemonSet support (#5675) * Adds note about DaemonSet support * Update docs/getting-started/install-endpoint.asciidoc Co-authored-by: Joe Peeples <[email protected]> * Update docs/release-notes/8.10.asciidoc Co-authored-by: Joe Peeples <[email protected]> * Update docs/serverless/edr-install-config/install-elastic-defend.mdx Co-authored-by: Joe Peeples <[email protected]> * updates wording --------- Co-authored-by: Joe Peeples <[email protected]> (cherry picked from commit a662e9e) # Conflicts: # docs/serverless/edr-install-config/install-elastic-defend.mdx * Delete docs/serverless directory and its contents --------- Co-authored-by: Benjamin Ironside Goldstein <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Adds note about DaemonSet support (#5675) * Adds note about DaemonSet support * Update docs/getting-started/install-endpoint.asciidoc Co-authored-by: Joe Peeples <[email protected]> * Update docs/release-notes/8.10.asciidoc Co-authored-by: Joe Peeples <[email protected]> * Update docs/serverless/edr-install-config/install-elastic-defend.mdx Co-authored-by: Joe Peeples <[email protected]> * updates wording --------- Co-authored-by: Joe Peeples <[email protected]> (cherry picked from commit a662e9e) # Conflicts: # docs/serverless/edr-install-config/install-elastic-defend.mdx * Delete docs/serverless directory and its contents --------- Co-authored-by: Benjamin Ironside Goldstein <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Adds note about DaemonSet support (#5675) * Adds note about DaemonSet support * Update docs/getting-started/install-endpoint.asciidoc Co-authored-by: Joe Peeples <[email protected]> * Update docs/release-notes/8.10.asciidoc Co-authored-by: Joe Peeples <[email protected]> * Update docs/serverless/edr-install-config/install-elastic-defend.mdx Co-authored-by: Joe Peeples <[email protected]> * updates wording --------- Co-authored-by: Joe Peeples <[email protected]> (cherry picked from commit a662e9e) # Conflicts: # docs/serverless/edr-install-config/install-elastic-defend.mdx * Delete docs/serverless directory and its contents --------- Co-authored-by: Benjamin Ironside Goldstein <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Adds note about DaemonSet support (#5675) * Adds note about DaemonSet support * Update docs/getting-started/install-endpoint.asciidoc Co-authored-by: Joe Peeples <[email protected]> * Update docs/release-notes/8.10.asciidoc Co-authored-by: Joe Peeples <[email protected]> * Update docs/serverless/edr-install-config/install-elastic-defend.mdx Co-authored-by: Joe Peeples <[email protected]> * updates wording --------- Co-authored-by: Joe Peeples <[email protected]> (cherry picked from commit a662e9e) # Conflicts: # docs/serverless/edr-install-config/install-elastic-defend.mdx * Delete docs/serverless directory and its contents --------- Co-authored-by: Benjamin Ironside Goldstein <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Adds note about DaemonSet support (#5675) * Adds note about DaemonSet support * Update docs/getting-started/install-endpoint.asciidoc Co-authored-by: Joe Peeples <[email protected]> * Update docs/release-notes/8.10.asciidoc Co-authored-by: Joe Peeples <[email protected]> * Update docs/serverless/edr-install-config/install-elastic-defend.mdx Co-authored-by: Joe Peeples <[email protected]> * updates wording --------- Co-authored-by: Joe Peeples <[email protected]> (cherry picked from commit a662e9e) # Conflicts: # docs/serverless/edr-install-config/install-elastic-defend.mdx * Delete docs/serverless directory and its contents --------- Co-authored-by: Benjamin Ironside Goldstein <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Adds note about DaemonSet support (#5675) * Adds note about DaemonSet support * Update docs/getting-started/install-endpoint.asciidoc Co-authored-by: Joe Peeples <[email protected]> * Update docs/release-notes/8.10.asciidoc Co-authored-by: Joe Peeples <[email protected]> * Update docs/serverless/edr-install-config/install-elastic-defend.mdx Co-authored-by: Joe Peeples <[email protected]> * updates wording --------- Co-authored-by: Joe Peeples <[email protected]> (cherry picked from commit 006f480) # Conflicts: # docs/serverless/edr-install-config/install-elastic-defend.mdx * Delete docs/serverless directory and its contents --------- Co-authored-by: Benjamin Ironside Goldstein <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Adds note about DaemonSet support (#5675) * Adds note about DaemonSet support * Update docs/getting-started/install-endpoint.asciidoc Co-authored-by: Joe Peeples <[email protected]> * Update docs/release-notes/8.10.asciidoc Co-authored-by: Joe Peeples <[email protected]> * Update docs/serverless/edr-install-config/install-elastic-defend.mdx Co-authored-by: Joe Peeples <[email protected]> * updates wording --------- Co-authored-by: Joe Peeples <[email protected]> (cherry picked from commit 006f480) # Conflicts: # docs/serverless/edr-install-config/install-elastic-defend.mdx * Delete docs/serverless directory and its contents --------- Co-authored-by: Benjamin Ironside Goldstein <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Fixes #5674
Previews:
8.10 release notes
Install Elastic Defend