Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process descendant filtering in event filters [ESS] #5626

Merged
merged 8 commits into from
Aug 6, 2024

Conversation

joepeeples
Copy link
Contributor

@joepeeples joepeeples commented Jul 30, 2024

Contributes to #5402 by adding to the ESS docs. ESS twin of #5672.

Preview

  • Event filters — Step 3 for Conditions has new substep for choosing Events or Process Descendants

Note

This PR also tests out the coming:[] tag in AsciiDoc, as an inline indicator of a feature's release availability. Once the feature is available in serverless, we'll merge another PR to update the serverless docs and also revise the hover text from "coming to" to "added in" or something similar.

Screenshot of tag
(body content in image is outdated, for illustrating the hover-over message only)

image

@joepeeples joepeeples added Team: EDR Workflows Formerly Defend Workflows, Onboarding and Lifecycle Management Feature: Elastic Defend Docset: ESS Issues that apply to docs in the Stack release v8.15.0 labels Jul 30, 2024
Copy link

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@joepeeples joepeeples changed the title Process descendant filtering in event filters Process descendant filtering in event filters [ESS] Jul 31, 2024
@joepeeples joepeeples marked this pull request as ready for review July 31, 2024 14:08
@joepeeples joepeeples requested a review from a team as a code owner July 31, 2024 14:08
@joepeeples joepeeples self-assigned this Jul 31, 2024
Copy link
Contributor

@gergoabraham gergoabraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

gergoabraham
gergoabraham previously approved these changes Jul 31, 2024
Copy link
Contributor

@gergoabraham gergoabraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

Copy link
Contributor

@gabriellandau gabriellandau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @joepeeples

@joepeeples joepeeples mentioned this pull request Aug 5, 2024
22 tasks
Copy link
Contributor

@jmikell821 jmikell821 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🥳

@joepeeples joepeeples merged commit cad139b into main Aug 6, 2024
3 checks passed
mergify bot pushed a commit that referenced this pull request Aug 6, 2024
* Update screenshot: Add event filter flyout

* First draft

* Revise

* Edit

* Testing out "added" tag

* Apply feedback from Gabriel

(cherry picked from commit cad139b)
@joepeeples joepeeples deleted the 5402-filter-process-descendants branch August 6, 2024 19:02
joepeeples added a commit that referenced this pull request Aug 6, 2024
* Update screenshot: Add event filter flyout

* First draft

* Revise

* Edit

* Testing out "added" tag

* Apply feedback from Gabriel

(cherry picked from commit cad139b)

Co-authored-by: Joe Peeples <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docset: ESS Issues that apply to docs in the Stack release Feature: Elastic Defend Team: EDR Workflows Formerly Defend Workflows, Onboarding and Lifecycle Management v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants