Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alerts table/page updates for 8.7 #3058

Merged
merged 12 commits into from
Mar 28, 2023
Merged

Alerts table/page updates for 8.7 #3058

merged 12 commits into from
Mar 28, 2023

Conversation

joepeeples
Copy link
Contributor

@joepeeples joepeeples commented Mar 21, 2023

Resolves #2956.

Previews

There are changes throughout both pages — updated existing screenshots/text, added new content, etc:

Features

This PR covers several new features all involving the Alerts page:

  • Updated KPI visualizations, including new Summary view type
  • Grouped alerts

Notes

  • The animated GIF illustrating the Treemap visualization has intentionally NOT been updated in this PR. That image will require quite a bit of technical setup to reproduce effectively. I've broken that work out as a separate issue (#3056) so that single GIF doesn't block us from shipping the rest of these Alerts page updates.

@github-actions
Copy link

Documentation previews:

Copy link

@christineweng christineweng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Visualization changes LGTM! I suggest adding a screenshot of the collapsed KPI visualization.

image

@joepeeples
Copy link
Contributor Author

Visualization changes LGTM! I suggest adding a screenshot of the collapsed KPI visualization.

Whoa, that's so cool! 🤩 I didn't realize that was a thing, must have overlooked that detail. I'll definitely add a screenshot and mention the functionality, thanks @christineweng!

@joepeeples joepeeples mentioned this pull request Mar 22, 2023
25 tasks
Copy link
Contributor

@nastasha-solomon nastasha-solomon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lot's of good content here. I left a handful of minor suggestions and one question. Everything else looks ✨ ah-mazing ✨ !

docs/detections/alerts-ui-manage.asciidoc Outdated Show resolved Hide resolved
docs/detections/alerts-ui-manage.asciidoc Outdated Show resolved Hide resolved
docs/detections/alerts-visualizations.asciidoc Outdated Show resolved Hide resolved
Copy link
Contributor

@benironside benironside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall! I think the Summary section is 🔥 🔥
Left some minor suggestions for your consideration

docs/detections/alerts-ui-manage.asciidoc Outdated Show resolved Hide resolved
docs/detections/alerts-ui-manage.asciidoc Outdated Show resolved Hide resolved
docs/detections/alerts-ui-manage.asciidoc Outdated Show resolved Hide resolved
docs/detections/alerts-ui-manage.asciidoc Outdated Show resolved Hide resolved
docs/detections/alerts-visualizations.asciidoc Outdated Show resolved Hide resolved
docs/detections/alerts-visualizations.asciidoc Outdated Show resolved Hide resolved
Copy link
Contributor

@jmikell821 jmikell821 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love all these updates! Except for a few small nits to add to the rest of the previous amazing feedback, this looks great! 🌟

docs/detections/alerts-ui-manage.asciidoc Outdated Show resolved Hide resolved
docs/detections/alerts-ui-manage.asciidoc Outdated Show resolved Hide resolved
docs/detections/alerts-ui-manage.asciidoc Outdated Show resolved Hide resolved
docs/detections/alerts-visualizations.asciidoc Outdated Show resolved Hide resolved
Co-authored-by: Janeen Mikell Roberts <[email protected]>
Copy link
Contributor

@stephmilovic stephmilovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a couple minor notes on the grouping section. LGTM! Thanks @joepeeples

@joepeeples joepeeples merged commit 95952bf into main Mar 28, 2023
mergify bot pushed a commit that referenced this pull request Mar 28, 2023
* Update existing screenshots

* First pass at Summary viz new section, etc.

* Small edit

* Add Group alerts section, images

* Various edits

* Add info on collapsing the viz section

* Apply suggestions from Nastasha & Bens review

Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
Co-authored-by: nastasha-solomon <[email protected]>

* Add [discrete] tags for proper AsciiDoc

* Apply suggestions from Janeen's review

Co-authored-by: Janeen Mikell Roberts <[email protected]>

* Apply suggestion from Steph's review

---------

Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
Co-authored-by: nastasha-solomon <[email protected]>
Co-authored-by: Janeen Mikell Roberts <[email protected]>
(cherry picked from commit 95952bf)
joepeeples added a commit that referenced this pull request Mar 28, 2023
* Update existing screenshots

* First pass at Summary viz new section, etc.

* Small edit

* Add Group alerts section, images

* Various edits

* Add info on collapsing the viz section

* Apply suggestions from Nastasha & Bens review

Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
Co-authored-by: nastasha-solomon <[email protected]>

* Add [discrete] tags for proper AsciiDoc

* Apply suggestions from Janeen's review

Co-authored-by: Janeen Mikell Roberts <[email protected]>

* Apply suggestion from Steph's review

---------

Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
Co-authored-by: nastasha-solomon <[email protected]>
Co-authored-by: Janeen Mikell Roberts <[email protected]>
(cherry picked from commit 95952bf)

Co-authored-by: Joe Peeples <[email protected]>
@joepeeples joepeeples deleted the 2956-alerts-page-8.7 branch March 28, 2023 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[META] Alerts table/page updates for 8.7
6 participants