-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alerts table/page updates for 8.7 #3058
Conversation
Documentation previews: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoa, that's so cool! 🤩 I didn't realize that was a thing, must have overlooked that detail. I'll definitely add a screenshot and mention the functionality, thanks @christineweng! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lot's of good content here. I left a handful of minor suggestions and one question. Everything else looks ✨ ah-mazing ✨ !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great overall! I think the Summary section is 🔥 🔥
Left some minor suggestions for your consideration
Co-authored-by: Benjamin Ironside Goldstein <[email protected]> Co-authored-by: nastasha-solomon <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love all these updates! Except for a few small nits to add to the rest of the previous amazing feedback, this looks great! 🌟
Co-authored-by: Janeen Mikell Roberts <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a couple minor notes on the grouping section. LGTM! Thanks @joepeeples
* Update existing screenshots * First pass at Summary viz new section, etc. * Small edit * Add Group alerts section, images * Various edits * Add info on collapsing the viz section * Apply suggestions from Nastasha & Bens review Co-authored-by: Benjamin Ironside Goldstein <[email protected]> Co-authored-by: nastasha-solomon <[email protected]> * Add [discrete] tags for proper AsciiDoc * Apply suggestions from Janeen's review Co-authored-by: Janeen Mikell Roberts <[email protected]> * Apply suggestion from Steph's review --------- Co-authored-by: Benjamin Ironside Goldstein <[email protected]> Co-authored-by: nastasha-solomon <[email protected]> Co-authored-by: Janeen Mikell Roberts <[email protected]> (cherry picked from commit 95952bf)
* Update existing screenshots * First pass at Summary viz new section, etc. * Small edit * Add Group alerts section, images * Various edits * Add info on collapsing the viz section * Apply suggestions from Nastasha & Bens review Co-authored-by: Benjamin Ironside Goldstein <[email protected]> Co-authored-by: nastasha-solomon <[email protected]> * Add [discrete] tags for proper AsciiDoc * Apply suggestions from Janeen's review Co-authored-by: Janeen Mikell Roberts <[email protected]> * Apply suggestion from Steph's review --------- Co-authored-by: Benjamin Ironside Goldstein <[email protected]> Co-authored-by: nastasha-solomon <[email protected]> Co-authored-by: Janeen Mikell Roberts <[email protected]> (cherry picked from commit 95952bf) Co-authored-by: Joe Peeples <[email protected]>
Resolves #2956.
Previews
There are changes throughout both pages — updated existing screenshots/text, added new content, etc:
Features
This PR covers several new features all involving the Alerts page:
Notes