Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Placeholder fields and Osquery UI updates #3045

Merged
merged 27 commits into from
Mar 28, 2023
Merged

Placeholder fields and Osquery UI updates #3045

merged 27 commits into from
Mar 28, 2023

Conversation

nastasha-solomon
Copy link
Contributor

@nastasha-solomon nastasha-solomon commented Mar 8, 2023 •
edited
Loading

Fixes #2981.

Previews:

@nastasha-solomon nastasha-solomon added Team: EDR Workflows Formerly Defend Workflows, Onboarding and Lifecycle Management Feature: Osquery v8.7.0 labels Mar 8, 2023
@nastasha-solomon nastasha-solomon self-assigned this Mar 8, 2023
@github-actions
Copy link

github-actions bot commented Mar 8, 2023

Documentation previews:

@nastasha-solomon nastasha-solomon marked this pull request as ready for review March 19, 2023 16:01
@szwarckonrad
Copy link

CC @tomsonpl @patrykkopycinski

@nastasha-solomon nastasha-solomon marked this pull request as draft March 19, 2023 17:07
@nastasha-solomon
Re-org
adb1fa9
@nastasha-solomon
Merge branch 'issue-2981-2872-osquery-replace-params' of github.com:e…
c566db6 
…lastic/security-docs into issue-2981-2872-osquery-replace-params
@nastasha-solomon nastasha-solomon marked this pull request as ready for review March 19, 2023 17:23
tomsonpl
tomsonpl approved these changes Mar 20, 2023
View reviewed changes
Copy link

@tomsonpl tomsonpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

joepeeples
joepeeples reviewed Mar 20, 2023
View reviewed changes
Copy link
Contributor

@joepeeples joepeeples left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff! Just added a couple small suggestions, thanks!

docs/osquery/osquery-placeholder-fields.asciidoc Outdated Show resolved Hide resolved
docs/osquery/osquery-placeholder-fields.asciidoc Outdated Show resolved Hide resolved
docs/osquery/osquery-placeholder-fields.asciidoc Outdated Show resolved Hide resolved
docs/osquery/osquery-placeholder-fields.asciidoc Outdated Show resolved Hide resolved
benironside
benironside reviewed Mar 20, 2023
View reviewed changes
Copy link
Contributor

@benironside benironside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks excellent overall, good examples and I think I could use this feature no problem after reading this — I left a few small suggestions for you to consider

docs/osquery/osquery-placeholder-fields.asciidoc Outdated Show resolved Hide resolved
docs/osquery/osquery-placeholder-fields.asciidoc Outdated Show resolved Hide resolved
docs/osquery/osquery-placeholder-fields.asciidoc Outdated Show resolved Hide resolved
docs/osquery/osquery-placeholder-fields.asciidoc Outdated Show resolved Hide resolved
docs/osquery/osquery-placeholder-fields.asciidoc Outdated Show resolved Hide resolved
docs/osquery/osquery-response-action.asciidoc Outdated Show resolved Hide resolved
nastasha-solomon and others added 7 commits March 21, 2023 17:44
@nastasha-solomon nastasha-solomon mentioned this pull request Mar 27, 2023
Closed
25 tasks
jmikell821
jmikell821 reviewed Mar 27, 2023
View reviewed changes
Copy link
Contributor

@jmikell821 jmikell821 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small comments, otherwise, looks good!

docs/osquery/osquery-placeholder-fields.asciidoc Outdated Show resolved Hide resolved
docs/osquery/osquery-placeholder-fields.asciidoc Outdated Show resolved Hide resolved
@nastasha-solomon nastasha-solomon merged commit 2cf53b7 into main Mar 28, 2023
mergify bot pushed a commit that referenced this pull request Mar 28, 2023
@nastasha-solomon @mergify
Placeholder fields and Osquery UI updates (#3045)
8324dd6 
Co-authored-by: Joe Peeples <[email protected]>
Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
Co-authored-by: Janeen Mikell Roberts <[email protected]>
(cherry picked from commit 2cf53b7)
@mergify mergify bot mentioned this pull request Mar 28, 2023
Merged
nastasha-solomon added a commit that referenced this pull request Mar 28, 2023
@mergify @joepeeples
@benironside @jmikell821 @nastasha-solomon
[8.7] Placeholder fields and Osquery UI updates (backport #3045) (#3080)
bd62899 
Co-authored-by: Joe Peeples <[email protected]>
Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
Co-authored-by: Janeen Mikell Roberts <[email protected]>
Co-authored-by: nastasha-solomon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benironside benironside benironside left review comments

@joepeeples joepeeples joepeeples left review comments

@jmikell821 jmikell821 jmikell821 left review comments

@tomsonpl tomsonpl tomsonpl approved these changes

@patrykkopycinski patrykkopycinski Awaiting requested review from patrykkopycinski

Assignees

@nastasha-solomon nastasha-solomon

Labels
Feature: Osquery Team: EDR Workflows Formerly Defend Workflows, Onboarding and Lifecycle Management v8.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Osquery query parameters can act as placeholders that will be replaced with event data
6 participants
@nastasha-solomon @szwarckonrad @tomsonpl @jmikell821 @joepeeples @benironside