Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Action connectors can be imported/exported with rules #3021

Merged
merged 19 commits into from
Mar 28, 2023
Merged

Action connectors can be imported/exported with rules #3021

merged 19 commits into from
Mar 28, 2023

Conversation

nastasha-solomon
Copy link
Contributor

@nastasha-solomon nastasha-solomon commented Feb 27, 2023 •
edited
Loading

Fixes #2892.

Previews:

  • Export and import rules - Made several changes:
    • Updated the decription for the Actions and connectors bullet.
    • Updated note under step 3 to include required privs for overwriting existing connectors and adding new ones.
    • Added steps 3e and 3g.
  • Import rules API - Updated note about privs and exported file.
  • Import rules | URL query parameters - Doc'd the new overwrite_action_connectors parameter.
  • Export rules API - Updated note about privs and exported file.

@nastasha-solomon nastasha-solomon self-assigned this Feb 27, 2023
@github-actions
Copy link

Documentation previews:

@nastasha-solomon nastasha-solomon marked this pull request as ready for review March 2, 2023 19:40
benironside
benironside reviewed Mar 7, 2023
View reviewed changes
Copy link
Contributor

@benironside benironside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, and I learned while reviewing it! Just made one suggestion in a few places

docs/detections/api/rules/rules-api-import.asciidoc Outdated Show resolved Hide resolved
docs/detections/rules-ui-manage.asciidoc Outdated Show resolved Hide resolved
docs/getting-started/detections-req.asciidoc Outdated Show resolved Hide resolved
WafaaNasr
WafaaNasr approved these changes Mar 9, 2023
View reviewed changes
Copy link

@WafaaNasr WafaaNasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!! 👏🏻

jmikell821
jmikell821 reviewed Mar 20, 2023
View reviewed changes
Copy link
Contributor

@jmikell821 jmikell821 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great updates to the priv reqs! LGTM!

@nastasha-solomon nastasha-solomon mentioned this pull request Mar 23, 2023
Closed
25 tasks
joepeeples
joepeeples reviewed Mar 27, 2023
View reviewed changes
Copy link
Contributor

@joepeeples joepeeples left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a couple of tiny nits to consider, thanks!

docs/detections/api/rules/rules-api-export.asciidoc Outdated Show resolved Hide resolved
docs/detections/api/rules/rules-api-import.asciidoc Outdated Show resolved Hide resolved
docs/getting-started/detections-req.asciidoc Outdated Show resolved Hide resolved
@nastasha-solomon nastasha-solomon merged commit e79d882 into main Mar 28, 2023
mergify bot pushed a commit that referenced this pull request Mar 28, 2023
@nastasha-solomon @mergify
Action connectors can be imported/exported with rules (#3021)
8104e27 
Co-authored-by: Joe Peeples <[email protected]>
(cherry picked from commit e79d882)
@mergify mergify bot mentioned this pull request Mar 28, 2023
Merged
nastasha-solomon added a commit that referenced this pull request Mar 28, 2023
@mergify @joepeeples @nastasha-solomon
[8.7] Action connectors can be imported/exported with rules (backport #…
f2c2fb8 
…3021) (#3078)

Co-authored-by: Joe Peeples <[email protected]>
Co-authored-by: nastasha-solomon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benironside benironside benironside left review comments

@joepeeples joepeeples joepeeples left review comments

@jmikell821 jmikell821 jmikell821 left review comments

@WafaaNasr WafaaNasr WafaaNasr approved these changes

Assignees

@nastasha-solomon nastasha-solomon

Labels
Feature: Connectors Feature: Rules Team: Security Platform Includes Cyber Threat Intelligence (CTI) team v8.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Action connectors can be imported/exported with rules
5 participants
@nastasha-solomon @WafaaNasr @jmikell821 @joepeeples @benironside